fix!: change ack processing in provider middleware

[MSalopek]

Fixes issue uncovered during gaia provider testing.

Provider middleware was not correctly handling all possible middlewares OnRecv calls.

Summary by CodeRabbit

• Bug Fixes
  • Modified the acknowledgment check in packet reception to enhance reliability in message handling.

[coderabbitai]

Walkthrough

Walkthrough

The IBCMiddleware struct in ibc_middleware.go has been updated to modify the acknowledgment check within the OnRecvPacket method. The change shifts the condition from checking ack.Success() to if ack == nil, altering how the method processes received packets based on acknowledgment presence.

Changes

File Path	Change Summary
x/ccv/provider/ibc_middleware.go	Changed acknowledgment check in OnRecvPacket from ack.Success() to ack == nil.

Possibly related issues

• Remove ICS4Wrapper from keepers and pass it as argument to IBC middleware constructor ibc-go#3371: This issue discusses restructuring the IBC middleware, which could be related to the middleware changes in the PR, aiming to streamline middleware interactions.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5bb6b1c and c91e7af.

Files selected for processing (1)

• x/ccv/provider/ibc_middleware.go (1 hunks)

Additional Context Used

Path-based Instructions (1)

x/ccv/provider/ibc_middleware.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (1)

x/ccv/provider/ibc_middleware.go (1)

123-123: Ensure proper handling when ack is nil.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.