Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move verifyMisbehavour to the top of misbehaviour_handle.go #2801

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

charleenfei
Copy link
Contributor

Description

closes: #2752

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

Codecov Report

Merging #2801 (3ba5a45) into main (cb92f6f) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2801   +/-   ##
=======================================
  Coverage   78.81%   78.81%           
=======================================
  Files         178      178           
  Lines       12293    12293           
=======================================
  Hits         9689     9689           
  Misses       2185     2185           
  Partials      419      419           
Impacted Files Coverage Δ
...ight-clients/06-solomachine/misbehaviour_handle.go 85.00% <100.00%> (ø)

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto commit message

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ay, nice one!

@colin-axner
Copy link
Contributor

colin-axner commented Nov 21, 2022

I'm happy to skip a changelog entry for this

@charleenfei charleenfei enabled auto-merge (squash) November 22, 2022 12:47
@charleenfei charleenfei merged commit f9b8d6a into main Nov 22, 2022
@charleenfei charleenfei deleted the charly/2752_move_code branch November 22, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move verifyMisbehaviour in solomachine to top of file
5 participants