Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move verifyMisbehaviour in solomachine to top of file #2752

Closed
3 tasks
colin-axner opened this issue Nov 14, 2022 · 0 comments · Fixed by #2801
Closed
3 tasks

move verifyMisbehaviour in solomachine to top of file #2752

colin-axner opened this issue Nov 14, 2022 · 0 comments · Fixed by #2801
Assignees
@charleenfei
Labels
06-solomachine good first issue Good for newcomers
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

It logically makes sense that is the first function in the file misbehaviour_handle.go. No changelog needed

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@charleenfei charleenfei self-assigned this Nov 21, 2022
@charleenfei charleenfei mentioned this issue Nov 21, 2022
Merged
9 tasks
@charleenfei charleenfei moved this to In review in ibc-go Nov 21, 2022
Repository owner moved this from In review to Todo in ibc-go Nov 22, 2022
@charleenfei charleenfei moved this from Todo to Done in ibc-go Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleenfei charleenfei

Labels
06-solomachine good first issue Good for newcomers
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor beta
Development

Successfully merging a pull request may close this issue.

chore: move verifyMisbehavour to the top of misbehaviour_handle.go cosmos/ibc-go
3 participants
@crodriguezvega @charleenfei @colin-axner