-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue#2004 : moved verifyMisbehviour function from update.go to misbehviour_handle.go #2376
issue#2004 : moved verifyMisbehviour function from update.go to misbehviour_handle.go #2376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up, @Daniyal98!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2376 +/- ##
=======================================
Coverage 78.59% 78.59%
=======================================
Files 178 178
Lines 12322 12322
=======================================
Hits 9684 9684
Misses 2206 2206
Partials 432 432
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Daniyal98!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks 🙏
To fix the goimports errors you should be able to run |
…04_verifyMisbehviour_file_change
…file_change fix goimport error
Yes, I believe its fixed now. Thank you! |
Description
closes: #2004
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes