Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move verifyMisbehaviour to misbehaviour_handle.go for 06-solomachine #2004

Closed
3 tasks
colin-axner opened this issue Aug 15, 2022 · 1 comment · Fixed by #2376
Closed
3 tasks

Move verifyMisbehaviour to misbehaviour_handle.go for 06-solomachine #2004

colin-axner opened this issue Aug 15, 2022 · 1 comment · Fixed by #2376
Assignees
@Daniyal98
Labels
06-solomachine good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

verifyMisbehaviour should be placed in misbehaviour_handle.go

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added good first issue Good for newcomers 06-solomachine type: code hygiene Clean up code but without changing functionality or interfaces labels Aug 15, 2022
@colin-axner colin-axner added this to the 02-client refactor RC milestone Aug 15, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Aug 15, 2022
@Daniyal98
Copy link
Contributor

Hello, I am looking to contribute on this issue.

@Daniyal98 Daniyal98 mentioned this issue Sep 25, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go Sep 25, 2022
@mergify mergify bot closed this as completed in #2376 Sep 29, 2022
mergify bot pushed a commit that referenced this issue Sep 29, 2022
@Daniyal98
issue#2004 : moved verifyMisbehviour function from update.go to misbe…
7dcfc2c 
…hviour_handle.go (#2376)

## Description



closes: #2004

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [x] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes
Repository owner moved this from In review to Done in ibc-go Sep 29, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Daniyal98 Daniyal98

Labels
06-solomachine good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor RC
2 participants
@colin-axner @Daniyal98