-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adapt ics27 controller claiming of channel capability #2146
Conversation
Please let me know if there's any additional tests to add. I'll update with a changelog entry also 👍 |
Codecov Report
@@ Coverage Diff @@
## main #2146 +/- ##
==========================================
- Coverage 79.28% 79.24% -0.04%
==========================================
Files 170 170
Lines 11855 11862 +7
==========================================
+ Hits 9399 9400 +1
- Misses 2040 2044 +4
- Partials 416 418 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! I need this merged in for #2147 :---)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aye nice! Needs a changelog entry :)
* [WIP] adding current code, test failures due to removal of claim capaiblities in mock IBCApp * [WIP] removing changes to fee tests * [WIP] removing whitespaces * adding nil check on chan caps in mock ibc module * adding changelog entry Co-authored-by: colin axnér <[email protected]> (cherry picked from commit 56f9da2) # Conflicts: # CHANGELOG.md # modules/apps/27-interchain-accounts/controller/ibc_middleware.go
…#2146) (#2150) * chore: adapt ics27 controller claiming of channel capability (#2146) * [WIP] adding current code, test failures due to removal of claim capaiblities in mock IBCApp * [WIP] removing changes to fee tests * [WIP] removing whitespaces * adding nil check on chan caps in mock ibc module * adding changelog entry Co-authored-by: colin axnér <[email protected]> (cherry picked from commit 56f9da2) # Conflicts: # CHANGELOG.md # modules/apps/27-interchain-accounts/controller/ibc_middleware.go * resolving conflicts * Update CHANGELOG.md Co-authored-by: Damian Nolan <[email protected]>
Description
nil
SendTx
is now ignored and looked up internallytesting/mock
IBCModule now only claims the channel capability if it is notnil
closes: #2033
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes