feat: implementing SubmitTx gRPC endpoint #2147

seantking · 2022-08-30T12:59:54Z

Description

closes: #2056

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

seantking · 2022-08-31T13:22:21Z

Shall I add an e2e for this test in a follow up PR?

colin-axner

Great work. Nice changelog entry. See suggestions. Approving as I think any changes to the MsgSubmitTx fields should be done in a followup (if we go that direction)

colin-axner · 2022-08-31T14:01:13Z

modules/apps/27-interchain-accounts/controller/keeper/msg_server.go

+	channelID, found := k.GetActiveChannelID(ctx, msg.ConnectionId, portID)
+	if !found {
+		return nil, sdkerrors.Wrapf(icatypes.ErrActiveChannelNotFound, "failed to retrieve active channel for port %s", portID)
+	}


Should we be taking in the channelID as the message argument? What's the UX benefit here? I'm thinking about a future where we remove the active channel mapping

cc @AdityaSripal

I suppose we could, but i think in that future we will break APIs anyway. So not sure its worth optimizing for that now

colin-axner · 2022-08-31T14:02:49Z

modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go

+	}{
+		{
+			"success", func() {
+				owner = TestOwnerAddress


set to TestOwnerAddress as default before tc.malleate()

colin-axner · 2022-08-31T14:04:35Z

modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go

+				Memo: "memo",
+			}
+
+			timeoutTimestamp := suite.chainA.GetContext().BlockTime().Add(time.Minute).UnixNano()


There's a suite.chainA.GetTimeoutHeight() function I think

colin-axner · 2022-08-31T14:04:51Z

modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go

+
+			tc.malleate() // malleate mutates test data
+
+			msg := types.NewMsgSubmitTx(owner, connectionID, clienttypes.NewHeight(0, 0), uint64(timeoutTimestamp), packetData)


use clienttypes.ZeroHeight() instead

colin-axner · 2022-08-31T14:06:35Z

Shall I add an e2e for this test in a follow up PR?

#2039, #2063

damiannolan

Looks more or less good to go, left some nits on tests and we should return sequence in the msg response afaik!
Nice work!

damiannolan · 2022-08-31T14:51:29Z

modules/apps/27-interchain-accounts/controller/keeper/msg_server.go

+		return nil, sdkerrors.Wrap(channeltypes.ErrChannelCapabilityNotFound, "module does not own channel capability")
+	}
+
+	_, err = k.SendTx(ctx, chanCap, msg.ConnectionId, portID, msg.PacketData, msg.TimeoutTimestamp)


We can include the sequence in the MsgSubmitTxResponse, right?

damiannolan · 2022-08-31T14:51:56Z

modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go


-	icatypes "github.com/cosmos/ibc-go/v5/modules/apps/27-interchain-accounts/controller/types"
+	"github.com/cosmos/ibc-go/v5/modules/apps/27-interchain-accounts/controller/types"
+	icacontrollertypes "github.com/cosmos/ibc-go/v5/modules/apps/27-interchain-accounts/controller/types"


nit: I think we normally alias this as just controllertypes

damiannolan · 2022-08-31T14:53:24Z

modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go

+	var (
+		path         *ibctesting.Path
+		owner        string
+		connectionID string


do we need to expose this var to mutate, or can we just use path.EndpointA.ConnectionID and mutate the path in malleate()?

I think it's fine to leave as is 🤝

You're right actually, I updated it. Thanks

damiannolan · 2022-08-31T14:55:48Z

modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go

+
+			tc.malleate() // malleate mutates test data
+
+			msg := types.NewMsgSubmitTx(owner, connectionID, clienttypes.NewHeight(0, 0), uint64(timeoutTimestamp), packetData)


we could expose the msg as test func level var and mutate the fields - owner, connection, packetData..etc in malleate()

it would remove the need for 3 test func level vars I think

* feat: implementing SubmitTx gRPC endpoint * test: adding failure cases * add capability test * chore: comment * chore: cleanup * chore: changelog * import & sequence * nits * refactor: clean up tests (cherry picked from commit 9019adf) # Conflicts: # modules/apps/27-interchain-accounts/controller/keeper/msg_server.go

* feat: implementing SubmitTx gRPC endpoint (#2147) * feat: implementing SubmitTx gRPC endpoint * test: adding failure cases * add capability test * chore: comment * chore: cleanup * chore: changelog * import & sequence * nits * refactor: clean up tests (cherry picked from commit 9019adf) # Conflicts: # modules/apps/27-interchain-accounts/controller/keeper/msg_server.go * resolving conflicts Co-authored-by: Sean King <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>

feat: implementing SubmitTx gRPC endpoint

09c053a

seantking force-pushed the sean/issue#2056-implement-rpc-handler-ica branch from 42a7a1c to 09c053a Compare August 30, 2022 13:00

seantking added 5 commits August 31, 2022 14:31

Merge branch 'main' into sean/issue#2056-implement-rpc-handler-ica

0a83377

test: adding failure cases

5168cfd

add capability test

c83cb4c

chore: comment

d64f950

chore: cleanup

06a5bd6

seantking marked this pull request as ready for review August 31, 2022 13:19

seantking requested review from colin-axner, AdityaSripal and damiannolan as code owners August 31, 2022 13:19

seantking requested review from chatton, charleenfei and crodriguezvega August 31, 2022 13:20

chore: changelog

743001a

seantking force-pushed the sean/issue#2056-implement-rpc-handler-ica branch from 28a487c to 743001a Compare August 31, 2022 13:27

colin-axner approved these changes Aug 31, 2022

View reviewed changes

damiannolan reviewed Aug 31, 2022

View reviewed changes

import & sequence

9bed0f5

damiannolan approved these changes Aug 31, 2022

View reviewed changes

seantking added 3 commits September 1, 2022 08:58

nits

084712a

refactor: clean up tests

74c9fbc

Merge branch 'main' into sean/issue#2056-implement-rpc-handler-ica

00c76d8

seantking enabled auto-merge (squash) September 1, 2022 07:24

seantking merged commit 9019adf into main Sep 1, 2022

seantking deleted the sean/issue#2056-implement-rpc-handler-ica branch September 1, 2022 07:49

damiannolan added the backport-to-v5.1.x label Sep 1, 2022

mergify bot mentioned this pull request Sep 1, 2022

feat: implementing SubmitTx gRPC endpoint (backport #2147) #2174

Merged

chatton mentioned this pull request Nov 7, 2022

Add git cliff toml to support generation of changelog #2697

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implementing SubmitTx gRPC endpoint #2147

feat: implementing SubmitTx gRPC endpoint #2147

seantking commented Aug 30, 2022

seantking commented Aug 31, 2022

colin-axner left a comment

colin-axner Aug 31, 2022

AdityaSripal Sep 7, 2022

colin-axner Aug 31, 2022

colin-axner Aug 31, 2022

colin-axner Aug 31, 2022

colin-axner commented Aug 31, 2022

damiannolan left a comment

damiannolan Aug 31, 2022

damiannolan Aug 31, 2022

damiannolan Aug 31, 2022

seantking Aug 31, 2022

seantking Sep 1, 2022

damiannolan Aug 31, 2022


		tc.malleate() // malleate mutates test data

		msg := types.NewMsgSubmitTx(owner, connectionID, clienttypes.NewHeight(0, 0), uint64(timeoutTimestamp), packetData)

feat: implementing SubmitTx gRPC endpoint #2147

feat: implementing SubmitTx gRPC endpoint #2147

Conversation

seantking commented Aug 30, 2022

Description

seantking commented Aug 31, 2022

colin-axner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

colin-axner commented Aug 31, 2022

damiannolan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment