Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce complexity of SerializeCosmosTx/DeserializeCosmosTx #452

Closed
3 tasks
seantking opened this issue Sep 29, 2021 · 0 comments · Fixed by #457
Closed
3 tasks

Reduce complexity of SerializeCosmosTx/DeserializeCosmosTx #452

seantking opened this issue Sep 29, 2021 · 0 comments · Fixed by #457
Assignees
@colin-axner
Labels
27-interchain-accounts audit Feedback from implementation audit type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
Interchain Accounts

Comments

@seantking
Copy link
Contributor

seantking commented Sep 29, 2021 •
edited
Loading

Summary

At present, the serialization/deserialization of transactions is overly complex. We can reduce complexity by forcing the TrySendTx API to only take an array of SDK messages rather than accepting a single SDK message.

DeserializeTx should be renamed to DeserializeCosmosTx

This task is dependent on #449

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking added type: code hygiene Clean up code but without changing functionality or interfaces 27-interchain-accounts audit Feedback from implementation audit labels Sep 29, 2021
@seantking seantking added this to the Interchain Accounts milestone Sep 29, 2021
@colin-axner colin-axner mentioned this issue Sep 30, 2021
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to Done in ibc-go Dec 30, 2021
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@alpe
Merge pull request cosmos#452 from CosmWasm/sdk_upgrade
315284e 
Upgrade cosmos-sdk to v0.42.0
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@Manav-Aggarwal @tzdybal
Fraud Proofs - one PR to rule them all again (cosmos#567)
8a3780e 
* Add gossip fraud proof capability over p2p (cosmos#452)

* Add types.proto for new tendermint version with abci methods

* Trigger Fraud Proof WIP

* Add new abci method in mocks all across tests

* Add fraudproof trigger

* Remove fraud trigger integration test

* Remove getAppHash from mock.on

* Write a fraudproof integration test

* Replace Generate with trigger

* Add skeleton to catch up and generate fraudproof after FPGM

* Remove triggerFraudProofGenerationMode and refactor

* Add generate fraud proof

* Wrap all fraudproof logic within a flag

* Update types.proto

* Add fraud proof verification WIP

* Update state/executor.go

Co-authored-by: Tomasz Zdybał <[email protected]>

* Refactor genAndGossipFraudProofIfNeeded

* Revert fraudproof type to remove serialization errors

* Remove local dependencies from go mod file

* Update go.mod file to have specific commit sha hash of celestiaorg/tendermint with new ABCI methods

* deps: update protobuf scripts & files to use correct version

Currently we need to use Manav's branch from celestiaorg/tendermint
fork.

* Update node/integration_test.go

Co-authored-by: Tomasz Zdybał <[email protected]>

* Call get_deps.sh and update abci types.proto

* Update spelling of comparison bc linter errors

* Change rollmint ethermint to optimint

* Delete version/types.proto file

* Add inline comment explaining integration test check

* Do not downgrade tendermint version

* Update proto/get_deps.sh

Co-authored-by: Tomasz Zdybał <[email protected]>

* deps: celestiaorg/tendermint@abci_fraud_proofs

* Refactor code into createAndStartNodes

Co-authored-by: Tomasz Zdybał <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
27-interchain-accounts audit Feedback from implementation audit type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
Interchain Accounts
Development

Successfully merging a pull request may close this issue.

Rename DeserializeTx, enforce []sdk.Msg usage in SerializeCosmosTx cosmos/ibc-go
3 participants
@crodriguezvega @seantking @colin-axner