Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Packet Data type #449

Closed
3 tasks
seantking opened this issue Sep 29, 2021 · 4 comments
Closed
3 tasks

Update Packet Data type #449

seantking opened this issue Sep 29, 2021 · 4 comments
Assignees
Labels
27-interchain-accounts audit Feedback from implementation audit

Comments

@seantking
Copy link
Contributor

seantking commented Sep 29, 2021

Summary

Update IBCAccountPacketData to have the following definition:

message InterchainAccountPacketData  {
    bytes data = 1;
    string memo = 2;
    Type  type = 3;
}

Investigate if we can remove IBCTxRaw & only use IBCTxBody. Future versions of ICA may use the data field for use other than executing messages which we need to take into consideration.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor

I think the data field should be repeated Anys

@seantking
Copy link
Contributor Author

seantking commented Sep 30, 2021

I think the data field should be repeated Anys

I was thinking the same until I considered that depending on the Type we may want data to not be a list of messages, which I guess is why it was left to be more arbitrary, to begin with.

Open to ideas, just food for thought :)

@colin-axner
Copy link
Contributor

colin-axner commented Sep 30, 2021

I was thinking the same until I considered that depending on the Type we may want data to not be a list of messages

An Any is:

type Any struct {
    TypeURL string
    Value []byte
}

Thus even if the Type isn't EXECUTE_TX, the list of Anys could be non sdk.Msg types as well

@seantking
Copy link
Contributor Author

Ah, yes that makes sense! I agree let's do repeated Any.

@crodriguezvega crodriguezvega moved this to Done in ibc-go Dec 30, 2021
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Mar 1, 2022
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Mar 1, 2022
* refactor connection handshake update messages

* refactor channel update msg handling

* fix chain id for timeout

* fix build

* refactor state based relaying (fixes update client bug on retries) (cosmos#435)

* bump sdk version to v0.41.3 (cosmos#430)

* bump sdk version

* bump SDK to v0.41.3

* inital work for refactoring state based relaying

* Modify relayPacketFromSequence

* update tendermint client to not prune light blocks (cosmos#437)

* Address comments and fix lint issues

* Fix lint issues

* Remove onRtyErr (lint issue)

* typo fix (cosmos#438)

* disable tm pruning (cosmos#441)

* update release naming (cosmos#442)

* Implement swagger docs and fix path validation (cosmos#434)

* Add swagger setup

* Add some routes docs and swagger ui

* Add few more route docs

* Add swagger docs for remaining routes

* Fix golint issues

* Fix unused lint issues

* check chain-id in AddChain

* add a light client database lock (cosmos#447)

Add a lock to prevent multiple processes from attempting to access the light client database at the same time. This typically resulted in unnecessary errors or even panics

* Close database connection even if second error triggers (cosmos#449)

Co-authored-by: Mark <[email protected]>

* address comments

Co-authored-by: akhilkumarpilli <[email protected]>
Co-authored-by: Afanti <[email protected]>
Co-authored-by: Akhil Kumar P <[email protected]>
Co-authored-by: Mark | Microtick <[email protected]>
Co-authored-by: Mark <[email protected]>

Co-authored-by: akhilkumarpilli <[email protected]>
Co-authored-by: Afanti <[email protected]>
Co-authored-by: Akhil Kumar P <[email protected]>
Co-authored-by: Mark | Microtick <[email protected]>
Co-authored-by: Mark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27-interchain-accounts audit Feedback from implementation audit
Projects
Archived in project
Development

No branches or pull requests

3 participants