Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Nudging) Fix gRPC for mint annual-provisions #650

Closed
wants to merge 1 commit into from

Conversation

shahankhatch
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #650 (efd733d) into main (2d2a610) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   12.33%   12.33%           
=======================================
  Files           8        8           
  Lines         697      697           
=======================================
  Hits           86       86           
  Misses        593      593           
  Partials       18       18           

@shahankhatch
Copy link
Contributor Author

Closing in favor of #649

@shahankhatch shahankhatch deleted the shahan/nudge_am_pr branch March 22, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants