Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC for mint annual-provisions #649

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Fix gRPC for mint annual-provisions #649

merged 1 commit into from
Feb 18, 2021

Conversation

amaury1093
Copy link
Contributor

Description

This PR fixes the error on CLI command q mint annual-provisions. It may affect other commands that deal with sdk.Dec.

It is related to cosmos/cosmos-sdk#8392.

To Test:

Run a gaiad node (doesn't need to be with the hub genesis, an dummy genesis works too).

Then run the q mint annual-provisions CLI command.

Before

./build/gaiad q mint annual-provisions           
Error: panic message redacted to hide potentially sensitive system info: panic
--snip--

After

./build/gaiad q mint annual-provisions
1300006837.287849604578641445

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Should we check other cmds?

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #649 (229463f) into main (2d2a610) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   12.33%   12.33%           
=======================================
  Files           8        8           
  Lines         697      697           
=======================================
  Hits           86       86           
  Misses        593      593           
  Partials       18       18           

@amaury1093
Copy link
Contributor Author

Should we check other cmds?

Yeah, I ran some other commands on the CLI, with my test genesis file, it works. I did not try on the hub though (might take some time on my side).

@zmanian
Copy link
Member

zmanian commented Feb 18, 2021

Thank you!

@alessio
Copy link
Contributor

alessio commented Feb 18, 2021

@marbar3778 the docker hub action is complaining :-/

@shahankhatch
Copy link
Contributor

@marbar3778 the docker hub action is complaining :-/

I suspect this is because of Amaury's membership. See the PR that works for this cherry-picked commit #650. I'm going to merge in and we can add Amaury to a team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants