-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gRPC for mint annual-provisions #649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Should we check other cmds?
Codecov Report
@@ Coverage Diff @@
## main #649 +/- ##
=======================================
Coverage 12.33% 12.33%
=======================================
Files 8 8
Lines 697 697
=======================================
Hits 86 86
Misses 593 593
Partials 18 18 |
Yeah, I ran some other commands on the CLI, with my test genesis file, it works. I did not try on the hub though (might take some time on my side). |
Thank you! |
@marbar3778 the docker hub action is complaining :-/ |
I suspect this is because of Amaury's membership. See the PR that works for this cherry-picked commit #650. I'm going to merge in and we can add Amaury to a team. |
Description
This PR fixes the error on CLI command
q mint annual-provisions
. It may affect other commands that deal with sdk.Dec.It is related to cosmos/cosmos-sdk#8392.
To Test:
Run a gaiad node (doesn't need to be with the hub genesis, an dummy genesis works too).
Then run the
q mint annual-provisions
CLI command.Before
After
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)