Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app dependency injection-based config init #9862

Closed
wants to merge 76 commits into from

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Aug 6, 2021

Description

Closes: #9864


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the stale label Sep 21, 2021
@github-actions github-actions bot added C:depinject Issues and PR related to depinject C:x/genutil genutil module issues labels Sep 23, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2021

This pull request introduces 1 alert when merging 233fa70 into f265287 - view on LGTM.com

new alerts:

  • 1 for Off-by-one comparison against length

@lgtm-com
Copy link

lgtm-com bot commented Sep 24, 2021

This pull request introduces 1 alert when merging 4b7d22e into bf11b1b - view on LGTM.com

new alerts:

  • 1 for Off-by-one comparison against length

@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2021

This pull request introduces 1 alert when merging 1e1d7c2 into 3138527 - view on LGTM.com

new alerts:

  • 1 for Off-by-one comparison against length

@github-actions github-actions bot closed this Oct 4, 2021
@aaronc aaronc removed the stale label Oct 4, 2021
@aaronc aaronc reopened this Oct 4, 2021
@aaronc aaronc closed this Nov 9, 2021
@alexanderbez alexanderbez deleted the aaronc/app-di-init branch April 22, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:depinject Issues and PR related to depinject C:x/auth C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial dependency-injection based app config
1 participant