Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update to TM v0.26.0 - Part II #2681

Merged
merged 4 commits into from
Nov 5, 2018

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Nov 4, 2018

This PR is a continuation of #2679. It complete the v0.26 update by finalizing proof and verification updates.

There are issues however:

  • A local testnet cannot get past 1 block.
  • TestVerifyMultiStoreQueryProof passes locally for me but not on CI.

/cc @jaekwon


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez requested a review from jaekwon as a code owner November 4, 2018 20:41
@alexanderbez alexanderbez added core T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Nov 4, 2018
@alexanderbez
Copy link
Contributor Author

alexanderbez commented Nov 5, 2018

Found the issue with local testnet. v0.26 requires the genesis time to be equal the block time at height 1.

However, our local testnet script/setup generates them per node so there is just a tinyyyy delta. I will update this process.

@jaekwon jaekwon mentioned this pull request Nov 5, 2018
@alexanderbez
Copy link
Contributor Author

And looks like TestVerifyMultiStoreQueryProof failing is actually due to a Golang bug: golang/go#27289

@jaekwon
Copy link
Contributor

jaekwon commented Nov 5, 2018

Bez is working on fixing localnet tests.

@jaekwon jaekwon merged commit 5847578 into bez/tm0.26-update-pt-1 Nov 5, 2018
@cwgoes cwgoes deleted the bez/tm0.26-update-pt-2 branch November 5, 2018 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants