R4R: Tendermint 0.26.0 #2633
Closed
R4R: Tendermint 0.26.0 #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaekwon
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2633 +/- ##
===========================================
- Coverage 58.82% 58.65% -0.18%
===========================================
Files 152 152
Lines 9424 9435 +11
===========================================
- Hits 5544 5534 -10
- Misses 3510 3537 +27
+ Partials 370 364 -6 |
|
Mmmm lots of tests still fail |
5 tasks
|
@alessio you may have to run |
|
@jaekwon Mind if I make a separate PR that simply addresses the amino API updates? The proof/verification logic can remain in this one after I merge/rebase? The PR is pretty big and I think it'll be easier to review this way. |
|
Yeah ok, sounds like that would help! |
They all also fail in CI though, which does do that. |
|
I'll take over this PR and attempt to address those issues. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced by #2679 and #2681