-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bianjie/lcd implementation #2177
Conversation
…to haoyang/lcd-implementation
Haoyang/lcd implementation
Refactor code according to lint result
Haoyang/lcd implementation
Refactor lcd code according to code reviewers
Fix errors in test_cover and test_lint
Haoyang/lcd implementation new
Bianjie/lcd implementation
Bianjie/lcd implementation
Thanks for the PR. Can we please split this, as possible, into separate PRs addressing individual concerns? That will help us review faster and ensure code quality. See some background discussion at #2173 (comment). |
@cwgoes this is the initial scope of the PR #2118 (comment):
|
Can we break (1), (2), (3), and (4) into separate PRs? That seems like a natural separation. Referencing also this section in
(I realize this is a pain but I think we need to start being strict about it at this stage in the development cycle especially) |
@cwgoes
|
@HaoyangLiu remember to add the prefix |
@fedekunze Thanks for your advice. I have added R4R in the title of #2192 and #2199 |
Proceed from: #2147
I just changed the source repo. The code is the same. I'm so sorry for bring troubles for all of you.