chore: fix spelling errors #19957
chore: fix spelling errors #19957
Conversation
WalkthroughWalkthroughThe change involves a minor correction in a log message within the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review Status
Configuration used: .coderabbit.yml
Files selected for processing (1)
- x/epochs/keeper/abci.go (1 hunks)
Additional Context Used
Path-based Instructions (1)
x/epochs/keeper/abci.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (1)
x/epochs/keeper/abci.go (1)
73-73: The typo correction in the log message enhances the clarity and readability. Good catch!
| } | ||
| err = k.EpochInfo.Set(ctx, epochInfo.Identifier, epochInfo) | ||
| if err != nil { | ||
| logger.Error(fmt.Sprintf("Error set epoch infor with identifier %s epoch number %d", epochInfo.Identifier, epochInfo.CurrentEpoch)) | ||
| logger.Error(fmt.Sprintf("Error set epoch info with identifier %s epoch number %d", epochInfo.Identifier, epochInfo.CurrentEpoch)) | ||
| return false, nil | ||
| } | ||
| if err := k.environment.BranchService.Execute(ctx, func(ctx context.Context) error { |
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [50-50]
Consider handling the error from k.environment.EventService.EventManager(ctx).Emit(&types.EventEpochEnd{...}) instead of ignoring it. Ignoring errors can lead to unnoticed issues.
- if err != nil {
- return false, nil
- }
+ if err != nil {
+ logger.Error(fmt.Sprintf("Failed to emit EventEpochEnd for identifier %s epoch number %d: %v", epochInfo.Identifier, epochInfo.CurrentEpoch, err))
+ return false, err
+ }📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [58-58]
Ignoring errors from k.AfterEpochEnd and k.BeforeEpochStart might be intentional to avoid halting the chain, but consider at least logging the error to aid in debugging.
- // purposely ignoring the error here not to halt the chain if the hook fails
+ // purposely ignoring the error here not to halt the chain if the hook fails
+ logger.Error(fmt.Sprintf("Error after epoch end with identifier %s epoch number %d: %v", epochInfo.Identifier, epochInfo.CurrentEpoch, err))
* main: (45 commits) build(deps): Bump github.com/decred/dcrd/dcrec/secp256k1/v4 from 4.2.0 to 4.3.0 (cosmos#19913) build(deps): Bump google.golang.org/grpc from 1.62.1 to 1.63.0 (cosmos#19929) test(types/address): add additional unit tests for address.LengthPrefix and a… (cosmos#19964) refactor(x/bank)!: remove Address.String() (cosmos#19954) build(deps): Bump github.com/prometheus/common from 0.51.1 to 0.52.2 (cosmos#19930) fix(x/epochs): Fix init genesis (cosmos#19958) feat(core,runtime): transaction service (exec mode) (cosmos#19953) fix(x/authz): non utf-8 characters in logs (cosmos#19923) build(deps): Bump golang.org/x/crypto from 0.21.0 to 0.22.0 (cosmos#19960) chore: fix spelling errors (cosmos#19957) fix(x/tx): don't shadow Amino marshalling error messages (cosmos#19955) refactor(types): loosen module.AppModule interface (cosmos#19951) feat(core): add `TxValidator` interface (cosmos#19950) build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 in /x/epochs (cosmos#19947) feat(x/epochs): upstream osmosis epoch module (cosmos#19697) build(deps): Bump bufbuild/buf-setup-action from 1.30.0 to 1.30.1 (cosmos#19928) refactor(x/genutil)!: remove Address.String() (cosmos#19926) docs(x/mint): Fix inconsistency in mint docs (cosmos#19915) build(deps): Bump github.com/regen-network/gocuke from 1.1.0 to 1.1.1 in /orm (cosmos#19920) feat: Integrate grpc configuration into client.toml (cosmos#19905) ...
This PR fixes typos in the codebase.
Please review it, and merge if everything is fine.
If there are proto changes, run
make proto-genand commit the changes.Summary by CodeRabbit