refactor(types): loosen module.AppModule interface #19951
Conversation
WalkthroughWalkthroughThe overarching modification involves refining the interface registration mechanism across various modules and mock types within the application. Specifically, it streamlines the process by conditionally invoking the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
julienrbrt
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yml
Files ignored due to path filters (1)
tests/starship/tests/go.modis excluded by!**/*.mod
Files selected for processing (6)
- runtime/app.go (1 hunks)
- testutil/mock/types_mock_appmodule.go (3 hunks)
- testutil/mock/types_module_module.go (4 hunks)
- types/module/module.go (2 hunks)
- x/epochs/module.go (2 hunks)
- x/genutil/module.go (2 hunks)
Additional Context Used
Path-based Instructions (6)
x/genutil/module.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/epochs/module.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.runtime/app.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.testutil/mock/types_module_module.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.testutil/mock/types_mock_appmodule.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.types/module/module.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (5)
x/genutil/module.go (1)
7-12: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-93]
The removal of the
RegisterInterfacesmethod aligns with the PR's objectives and simplifies the interface registration logic within the Cosmos SDK.x/epochs/module.go (1)
9-14: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-95]
The removal of the
RegisterInterfacesfunction aligns with the PR's objectives to simplify the interface registration logic. Note: The summary mentions the removal of an import related toregistry, which is not visible in the provided code snippet. This discrepancy does not affect the approval of the changes made.runtime/app.go (1)
71-73: The addition of a conditional type assertion in theRegisterModulesfunction enhances the flexibility of interface registration within the Cosmos SDK, aligning with the PR's objectives.testutil/mock/types_module_module.go (1)
9-14: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-261]
The removal of the
RegisterInterfacesmethod from mock implementations aligns with the PR's objectives to simplify the interface registration logic and ensures that the mocks remain consistent with the updated interfaces.testutil/mock/types_mock_appmodule.go (1)
10-15: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-255]
The removal of
RegisterInterfacesfrom the mock implementations aligns with the PR's objectives and is correctly reflected in the changes. Ensure that any tests or other code relying on these mocks are updated accordingly to accommodate the absence ofRegisterInterfaces.
|
* main: (45 commits) build(deps): Bump github.com/decred/dcrd/dcrec/secp256k1/v4 from 4.2.0 to 4.3.0 (cosmos#19913) build(deps): Bump google.golang.org/grpc from 1.62.1 to 1.63.0 (cosmos#19929) test(types/address): add additional unit tests for address.LengthPrefix and a… (cosmos#19964) refactor(x/bank)!: remove Address.String() (cosmos#19954) build(deps): Bump github.com/prometheus/common from 0.51.1 to 0.52.2 (cosmos#19930) fix(x/epochs): Fix init genesis (cosmos#19958) feat(core,runtime): transaction service (exec mode) (cosmos#19953) fix(x/authz): non utf-8 characters in logs (cosmos#19923) build(deps): Bump golang.org/x/crypto from 0.21.0 to 0.22.0 (cosmos#19960) chore: fix spelling errors (cosmos#19957) fix(x/tx): don't shadow Amino marshalling error messages (cosmos#19955) refactor(types): loosen module.AppModule interface (cosmos#19951) feat(core): add `TxValidator` interface (cosmos#19950) build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 in /x/epochs (cosmos#19947) feat(x/epochs): upstream osmosis epoch module (cosmos#19697) build(deps): Bump bufbuild/buf-setup-action from 1.30.0 to 1.30.1 (cosmos#19928) refactor(x/genutil)!: remove Address.String() (cosmos#19926) docs(x/mint): Fix inconsistency in mint docs (cosmos#19915) build(deps): Bump github.com/regen-network/gocuke from 1.1.0 to 1.1.1 in /orm (cosmos#19920) feat: Integrate grpc configuration into client.toml (cosmos#19905) ...
Description
Follow-up of this comment: #19697 (review)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit