Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Refactor LCD endpoints #1813

Closed
wants to merge 1 commit into from
Closed

WIP: Refactor LCD endpoints #1813

wants to merge 1 commit into from

Conversation

NodeGuy
Copy link
Contributor

@NodeGuy NodeGuy commented Jul 25, 2018 •
edited
Loading

Fix luniehq/lunie#1010

  • Linked to github-issue with discussion and accepted design
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@NodeGuy NodeGuy mentioned this pull request Jul 25, 2018
Closed
@fedekunze fedekunze mentioned this pull request Jul 25, 2018
Closed
@NodeGuy NodeGuy closed this Aug 7, 2018
@NodeGuy NodeGuy deleted the david-fede/lcd-rest branch August 7, 2018 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NodeGuy @rigelrozanski