Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Governance LCD Routes #1762

Closed
jackzampolin opened this issue Jul 19, 2018 · 9 comments
Closed

Document Governance LCD Routes #1762

jackzampolin opened this issue Jul 19, 2018 · 9 comments
Assignees
Labels
C:x/gov T:Docs Changes and features related to documentation.

Comments

@jackzampolin
Copy link
Member

Currently the LCD routes for governance are completely undocumented

https://github.com/cosmos/cosmos-sdk/blob/develop/x/gov/client/rest/rest.go#L27

@jackzampolin
Copy link
Member Author

They might want to be added to this doc: https://github.com/cosmos/cosmos-sdk/blob/develop/docs/light/api.md but we also may want to split LCD routes up by module based on my understanding.

@fedekunze
Copy link
Collaborator

@jackzampolin I'm working on this with @NodeGuy through #1813, maybe we could also document those routes

@rigelrozanski rigelrozanski added the T:Docs Changes and features related to documentation. label Jul 25, 2018
@jackzampolin
Copy link
Member Author

That would be awesome @fedekunze!

@fedekunze
Copy link
Collaborator

@jackzampolin Cool, will work on this too then !

@fedekunze fedekunze added the lcd label Jul 30, 2018
@fedekunze
Copy link
Collaborator

@jackzampolin we should have one issue for LCD routes in each of the modules. Note that there's also this LCD .yaml file with this information (with is clearly outdated).
You can paste the content to Swagger editor to have a better perspective

@jackzampolin
Copy link
Member Author

jackzampolin commented Jul 30, 2018

@fedekunze Agree on issue for each module. I'll get those opened.

On the swagger file, we should be able to generate the API docs from that if we have it updated. Why don't we just change this issue to be one to update the swagger doc?

This also raises the question weather or not each module needs it's own swagger.yaml...

Thoughts @fedekunze

@fedekunze
Copy link
Collaborator

@jackzampolin Agree on changing the issue and update the API docs for swagger automatically. Since we'll eventually have independent developers creating their own modules, I guess it makes sense for each of them to have it's own swagger.yaml file.

We currently have have this file for modules but it isn't included. I'd suggest for each module to have at least links to the Specs, GoDocs ( which are referred as API on the file) and Gaia-lite API (i.e LCD), as well as an overall description of the module and it's functionalities. This Modules file would be within the Cosmos documentation under the Modules section, which currently has a tutorial/walk-through (would also suggest moving that content to another section with another name).

@fedekunze
Copy link
Collaborator

@jackzampolin This is also related #1020

@fedekunze
Copy link
Collaborator

Closed by #2066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gov T:Docs Changes and features related to documentation.
Projects
None yet
Development

No branches or pull requests

5 participants