-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/gov): remove gov vote and proposal based telemetry #17910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
added
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
backport/v0.50.x
PR scheduled for inclusion in the v0.50's next stable release
labels
Sep 27, 2023
github-prbot
requested review from
a team,
kocubinski and
samricotta
and removed request for
a team
September 27, 2023 16:26
alexanderbez
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
julienrbrt
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a Client Breaking Changelog?
julienrbrt
changed the title
chore: remove gov vote and proposal based telemetry
refactor(gov): remove gov vote and proposal based telemetry
Sep 27, 2023
julienrbrt
changed the title
refactor(gov): remove gov vote and proposal based telemetry
refactor(x/gov): remove gov vote and proposal based telemetry
Sep 27, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
(cherry picked from commit 5e53fb2) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
(cherry picked from commit 5e53fb2) # Conflicts: # CHANGELOG.md # x/gov/keeper/msg_server.go
julienrbrt
added a commit
that referenced
this pull request
Sep 27, 2023
#17910) (#17915) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>
julienrbrt
added a commit
that referenced
this pull request
Sep 27, 2023
#17910) (#17916) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Oct 9, 2023
cosmos#17910) (cosmos#17916) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
backport/v0.50.x
PR scheduled for inclusion in the v0.50's next stable release
C:x/gov
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removes telemetry for votes and proposals as the data will be incorrect
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change