Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scripts which rely on counting proposals #9019

Open
JimLarson opened this issue Mar 1, 2024 · 3 comments
Open

Upgrade scripts which rely on counting proposals #9019

JimLarson opened this issue Mar 1, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@JimLarson
Copy link
Contributor

What is the Problem Being Solved?

In cosmos-sdk 0.47, they removed telemetry for counting votes and proposals. It was incorrectly counting votes. They suggest using alternatives, such as state streaming. cosmos/cosmos-sdk#17910

We have some scripts that rely on counting proposals which need to be upgraded.

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@JimLarson JimLarson added the enhancement New feature or request label Mar 1, 2024
@dckc
Copy link
Member

dckc commented Mar 1, 2024

We have some scripts that rely on counting proposals

For example?

@JimLarson JimLarson assigned JimLarson and unassigned mhofman Mar 22, 2024
@JimLarson
Copy link
Contributor Author

@mhofman I've been asked to drive this, but could you please give me a pointer to the scripts you're concerned about?

@mhofman
Copy link
Member

mhofman commented Mar 22, 2024

@mhofman I've been asked to drive this, but could you please give me a pointer to the scripts you're concerned about?

I don't specifically remember right now, but when auditing code which relied on query proposal, I noticed some surrounding code which relied on proposal count to guess the next proposal number. I think you can grep for proposal_id across our repos to find most location which may be involved with proposal querying. Looking for variants of gov proposal[s] might also lead you there.

@ivanlei ivanlei assigned ivanlei and unassigned JimLarson Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants