chore(crypto): update btcec to v2 #13513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elias-orijtech
force-pushed
the
main
branch
3 times, most recently
from
53b5eb2 to
88fc4e2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13513 +/- ##
==========================================
- Coverage 53.93% 53.93% -0.01%
==========================================
Files 645 645
Lines 55681 55679 -2
==========================================
- Hits 30033 30031 -2
Misses 23223 23223
Partials 2425 2425
|
odeke-em
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
LGTM, thank you @elias-orijtech! Kindly pinging @julienrbrt @tac0turtle and others for co-review.
|
Can you clarify if this is backwards compatible. |
|
It is backwards compatible. See tendermint/tendermint#9250 (comment) |
|
@elias-orijtech this change brought some good performance improvements for the cryptography benchmarks per https://dashboard.bencher.orijtech.com/benchmark/d892b345308f4a7a82222ee9e6ec1bff |
julienrbrt
approved these changes
Oct 15, 2022
| @@ -122,8 +122,10 @@ github.com/bgentry/speakeasy v0.1.0 h1:ByYyxL9InA1OWqxJqqp2A5pYHUrCiAL6K3J+LKSsQ | |||
| github.com/bgentry/speakeasy v0.1.0/go.mod h1:+zsyZBPWlz7T6j88CTgSN5bM796AkVf0kBD4zp0CCIs= | |||
| github.com/btcsuite/btcd v0.0.0-20190115013929-ed77733ec07d/go.mod h1:d3C0AkH6BRcvO8T0UEPu53cnw4IbV63x1bEjildYhO0= | |||
| github.com/btcsuite/btcd v0.20.1-beta/go.mod h1:wVuoA8VJLEcwgqHBwHmzLRazpKxTv13Px/pDuV7OomQ= | |||
| github.com/btcsuite/btcd v0.22.2 h1:vBZ+lGGd1XubpOWO67ITJpAEsICWhA0YzqkcpkgNBfo= | |||
There was a problem hiding this comment.
In the meantime we've bumped this to v0.22.2. Shouldn't we keep this version instead of reverting to v0.22.1
There was a problem hiding this comment.
Good catch. Done.
|
@tac0turtle would you like us to merge this change? Thank you. |
Similar to Tendermint's PR, tendermint/tendermint#9250 Note that crypto/ledger is not updated in this PR, because if its dependency on the R and S values being exposed by ParseDERSignature. Updates cosmos#13423 Signed-off-by: Elias Naur <[email protected]>
|
Seems like we need ledger to be somehow ported too: https://github.com/cosmos/cosmos-sdk/actions/runs/3594121426/jobs/6051975194 |
This was referenced Dec 1, 2022
yihuang
pushed a commit
that referenced
this pull request
Feb 7, 2023
Similar to Tendermint's PR, tendermint/tendermint#9250 Note that crypto/ledger is not updated in this PR, because if its dependency on the R and S values being exposed by ParseDERSignature. Updates #13423 Signed-off-by: Elias Naur <[email protected]> Signed-off-by: Elias Naur <[email protected]> Co-authored-by: Marko <[email protected]>
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Similar to Tendermint's PR, tendermint/tendermint#9250 Note that crypto/ledger is not updated in this PR, because if its dependency on the R and S values being exposed by ParseDERSignature. Updates cosmos#13423 Signed-off-by: Elias Naur <[email protected]> Signed-off-by: Elias Naur <[email protected]> Co-authored-by: Marko <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Tendermint's PR,
tendermint/tendermint#9250
Note that crypto/ledger is not updated in this PR, because if its dependency on the R and S values being exposed by ParseDERSignature.
Closes #13423
CC @odeke-em