Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/btcsuite/btcd/btcec to github.com/btcsuite/btcd/btcec/v2 #13423

Closed
parihaaraka opened this issue Sep 29, 2022 · 6 comments · Fixed by #13513
Closed

Bump github.com/btcsuite/btcd/btcec to github.com/btcsuite/btcd/btcec/v2 #13423

parihaaraka opened this issue Sep 29, 2022 · 6 comments · Fixed by #13513

Comments

@parihaaraka
Copy link

No way to update multi-blockchain services due to broken dependences.

  • tendermint has got the patch already
@julienrbrt
Copy link
Member

julienrbrt commented Oct 7, 2022 •
edited
Loading

Great! We were actually blocked with the new version: #12197.

@parihaaraka
Copy link
Author

Guys, its very important. Old btcd unable to read block 757922

@julienrbrt julienrbrt self-assigned this Oct 10, 2022
@julienrbrt julienrbrt moved this to 📝 Todo in Cosmos-SDK Oct 10, 2022
@julienrbrt
Copy link
Member

julienrbrt commented Oct 10, 2022 •
edited
Loading

I am going to unassign myself from this. I could copy what the TM PR does, but I do not yet entirely understand the lib, so I'd rather have someone else do it.
@odeke-em / @elias-orijtech, could you have a look?

@julienrbrt julienrbrt removed their assignment Oct 10, 2022
@odeke-em
Copy link
Collaborator

@julienrbrt we did review it in Tendermint and @elias-orijtech did give an OK on that repo, I shall kindly ping him again here too.

@elias-orijtech elias-orijtech mentioned this issue Oct 11, 2022
Merged
elias-orijtech added a commit to elias-orijtech/cosmos-sdk that referenced this issue Oct 11, 2022
@elias-orijtech
chore(crypto): update btcec to v2
88fc4e2 
Similar to Tendermint's PR,

tendermint/tendermint#9250

Note that crypto/ledger is not updated in this PR, because if its
dependency on the R and S values being exposed by ParseDERSignature.

Updates cosmos#13423

Signed-off-by: Elias Naur <[email protected]>
@parihaaraka
Copy link
Author

@elias-orijtech Trying to use your fork. Did you resolve the issue?

go: x/pkg/blockchains/cosmos imports
	github.com/cosmos/gaia/v5/app imports
	github.com/cosmos/cosmos-sdk/simapp: github.com/elias-orijtech/cosmos-sdk/[email protected]: parsing go.mod:
	module declares its path as: cosmossdk.io/simapp
	        but was required as: github.com/cosmos/cosmos-sdk/simapp

elias-orijtech added a commit to elias-orijtech/cosmos-sdk that referenced this issue Oct 14, 2022
@elias-orijtech
chore(crypto): update btcec to v2
33efd07 
Similar to Tendermint's PR,

tendermint/tendermint#9250

Note that crypto/ledger is not updated in this PR, because if its
dependency on the R and S values being exposed by ParseDERSignature.

Updates cosmos#13423

Signed-off-by: Elias Naur <[email protected]>
@elias-orijtech
Copy link
Contributor

Not sure what you're referring to, but I've rebased the PR, fixing a bunch of merge conflicts.

elias-orijtech added a commit to elias-orijtech/cosmos-sdk that referenced this issue Oct 16, 2022
@elias-orijtech
chore(crypto): update btcec to v2
bc9101f 
Similar to Tendermint's PR,

tendermint/tendermint#9250

Note that crypto/ledger is not updated in this PR, because if its
dependency on the R and S values being exposed by ParseDERSignature.

Updates cosmos#13423

Signed-off-by: Elias Naur <[email protected]>
tac0turtle added a commit that referenced this issue Oct 17, 2022
@elias-orijtech @tac0turtle
chore(crypto): update btcec to v2 (#13513)
ed9cd41 
Similar to Tendermint's PR,

tendermint/tendermint#9250

Note that crypto/ledger is not updated in this PR, because if its
dependency on the R and S values being exposed by ParseDERSignature.

Updates #13423

Signed-off-by: Elias Naur <[email protected]>

Signed-off-by: Elias Naur <[email protected]>
Co-authored-by: Marko <[email protected]>
Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK Oct 17, 2022
@tac0turtle tac0turtle removed this from Cosmos-SDK Oct 27, 2022
@glnro glnro mentioned this issue Feb 6, 2023
Merged
yihuang pushed a commit that referenced this issue Feb 7, 2023
@elias-orijtech @tac0turtle @yihuang
chore(crypto): update btcec to v2 (#13513)
c6efab6 
Similar to Tendermint's PR,

tendermint/tendermint#9250

Note that crypto/ledger is not updated in this PR, because if its
dependency on the R and S values being exposed by ParseDERSignature.

Updates #13423

Signed-off-by: Elias Naur <[email protected]>

Signed-off-by: Elias Naur <[email protected]>
Co-authored-by: Marko <[email protected]>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this issue May 22, 2023
@elias-orijtech @tac0turtle
chore(crypto): update btcec to v2 (cosmos#13513)
174cdd5 
Similar to Tendermint's PR,

tendermint/tendermint#9250

Note that crypto/ledger is not updated in this PR, because if its
dependency on the R and S values being exposed by ParseDERSignature.

Updates cosmos#13423

Signed-off-by: Elias Naur <[email protected]>

Signed-off-by: Elias Naur <[email protected]>
Co-authored-by: Marko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(crypto): update btcec to v2 elias-orijtech/cosmos-sdk
4 participants
@odeke-em @parihaaraka @julienrbrt @elias-orijtech