Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: all: remove map iteration non-determinism with keys + sorting #13377

Merged

Conversation

@odeke-em odeke-em requested a review from a team as a code owner September 24, 2022 03:22
@odeke-em odeke-em enabled auto-merge (squash) September 24, 2022 03:22
@odeke-em
Copy link
Collaborator Author

Kind ping to @marbar3778 @julienrbrt @alexanderbez and FYI to @elias-orijtech @willpoint

@odeke-em odeke-em force-pushed the fix-reduce-map-iteration-non-determinism-with-keys+sorting branch 2 times, most recently from b06455f to f5cde85 Compare September 24, 2022 03:29
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Merging #13377 (e6c5604) into main (b76f338) will increase coverage by 0.82%.
The diff coverage is 75.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13377      +/-   ##
==========================================
+ Coverage   54.14%   54.97%   +0.82%     
==========================================
  Files         651      674      +23     
  Lines       56055    57520    +1465     
==========================================
+ Hits        30353    31623    +1270     
+ Misses      23280    23246      -34     
- Partials     2422     2651     +229     
Impacted Files Coverage Δ
baseapp/baseapp.go 76.58% <0.00%> (-0.55%) ⬇️
x/group/keeper/invariants.go 44.73% <50.00%> (-0.34%) ⬇️
types/module/module.go 65.93% <66.66%> (-0.15%) ⬇️
orm/model/ormdb/json.go 66.66% <100.00%> (ø)
store/rootmulti/store.go 74.03% <100.00%> (+0.41%) ⬆️
types/coin.go 94.51% <100.00%> (ø)
simapp/test_helpers.go
simapp/upgrades.go
simapp/genesis.go
simapp/app.go
... and 45 more

@odeke-em odeke-em force-pushed the fix-reduce-map-iteration-non-determinism-with-keys+sorting branch from f5cde85 to 63ff150 Compare September 24, 2022 03:52
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tac0turtle tac0turtle disabled auto-merge September 24, 2022 04:27
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt enabled auto-merge (squash) September 24, 2022 13:24
@julienrbrt julienrbrt merged commit abdf61e into main Sep 24, 2022
@julienrbrt julienrbrt deleted the fix-reduce-map-iteration-non-determinism-with-keys+sorting branch September 24, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants