Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit Types v0.46..v0.47 #14257

Closed
Tracked by #13456
tac0turtle opened this issue Dec 11, 2022 · 2 comments · Fixed by #14283
Closed
Tracked by #13456

Audit Types v0.46..v0.47 #14257

tac0turtle opened this issue Dec 11, 2022 · 2 comments · Fixed by #14283
Assignees
@tac0turtle @julienrbrt

Comments

@tac0turtle
Copy link
Member

No description provided.

@tac0turtle tac0turtle mentioned this issue Dec 11, 2022
Closed
54 tasks
@tac0turtle tac0turtle changed the title Types Audit Types v0.46..v0.47 Dec 11, 2022
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK Dec 11, 2022
@julienrbrt julienrbrt mentioned this issue Dec 12, 2022
Merged
19 tasks
@julienrbrt
Copy link
Member

julienrbrt commented Dec 13, 2022 •
edited
Loading

As mempool have their audit (#14259), I've skipped it in my review.
Given the discussion of #13554, I think we should partly revert: #13377 / #13349 as it was deemed unnecessary.
Other than that lgtm.

@julienrbrt julienrbrt mentioned this issue Dec 13, 2022
Merged
19 tasks
@tac0turtle
Copy link
Member Author

Generally in support of this. It's a minor thing so shouldn't block

Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK Dec 13, 2022
@tac0turtle tac0turtle removed this from Cosmos-SDK Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

@julienrbrt julienrbrt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: types audit cosmos/cosmos-sdk
2 participants
@tac0turtle @julienrbrt