-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit only on error code? #91
Comments
look like a bug in the commit hook |
Indeed, what are you using to create the commit-hook? |
The problem isn't the hook itself. It seems like to me, all output from programs executed by the git hook forcefully redirect standard out to standard err. I've verify this by running the program directly and it outputs to stdout. When running from the githook, it redirects to stderr. Perhaps my question is also on why it was decided to terminate execution when there is a message on stderr even though the exit code signals it is okay? In terms out logging and outputting messages, many programs I see can emit warnings (which generally goes to stderr), not just errors. When there is an error, it should be terminating with an exit code greater than 0. |
One solution, when there is |
So I have a post-commit hook which actually undo a commit if the history is not fully linear. Basically, it seems like any output that is made thru a commit hook, will end up on stderr. Since the code checks against that, it never gets to the tagging.
The text was updated successfully, but these errors were encountered: