Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doens't handle git commit callback properly #108

Closed
e-cloud opened this issue Sep 20, 2016 · 2 comments
Closed

doens't handle git commit callback properly #108

e-cloud opened this issue Sep 20, 2016 · 2 comments

Comments

@e-cloud
Copy link
Contributor

e-cloud commented Sep 20, 2016

I have a git hook to check code style before commit(using eslint). If my code has error style, commit will not continue. If only have warnings, they will be shown, but commit can continue.

now standard-version will perform a release commit, which will also trigger the git hook.

However, it treat all stderr as illegal and just exit without continuing to perform git tag.

see the code

i think it should either prevent the git hooks when committing or improve the error handler

@stevemao
Copy link
Member

duplicate of #91?

@e-cloud
Copy link
Contributor Author

e-cloud commented Sep 20, 2016

looks like you are right

@e-cloud e-cloud closed this as completed Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants