Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChemPy [ready for review] #13310

Merged
merged 24 commits into from
Dec 8, 2020
Merged

Add ChemPy [ready for review] #13310

merged 24 commits into from
Dec 8, 2020

Conversation

bjodah
Copy link
Member

@bjodah bjodah commented Nov 24, 2020

This builds upon gh-12678, it bumps the version of one of the requirements. Hopefully it also regenerates CI logs which are no longer available in the referenced pull request.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there
  • When in trouble be please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/chemicals, recipes/dot2tex, recipes/pyneqsys, recipes/pyodesys, recipes/sym) and found some lint.

Here's what I've got...

For recipes/chemicals:

  • Feedstock with the same name exists in conda-forge.

For recipes/chemicals:

  • noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

For recipes/dot2tex:

  • noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

For recipes/pyneqsys:

  • noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

For recipes/sym:

  • noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dot2tex, recipes/pyneqsys, recipes/pyodesys, recipes/sym) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/chempy, recipes/dot2tex, recipes/pyneqsys, recipes/pyodesys, recipes/sym) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/chempy, recipes/dot2tex, recipes/pyneqsys, recipes/pyodesys, recipes/sym) and found some lint.

Here's what I've got...

For recipes/pyodesys:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/chempy, recipes/dot2tex, recipes/pyneqsys, recipes/pyodesys, recipes/sym) and found some lint.

Here's what I've got...

For recipes/pyodesys:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/chempy, recipes/dot2tex, recipes/pyneqsys, recipes/pyodesys, recipes/sym) and found it was in an excellent condition.

@bjodah
Copy link
Member Author

bjodah commented Nov 24, 2020

cc @ProfLeao

@ProfLeao
Copy link
Contributor

cc @ProfLeao

Thanks for the mention. Any tasks still pending for the inclusion of version 0.8.1?

@bjodah
Copy link
Member Author

bjodah commented Nov 24, 2020

I don't think so, I just wanted to see if you could think of anything. If not I think this is ready. So I guess we'll simply wait for someone to find the time to review. Thank you for getting started with this and being willing to help maintain the recipes!.

@ProfLeao
Copy link
Contributor

I don't think so, I just wanted to see if you could think of anything. If not I think this is ready. So I guess we'll simply wait for someone to find the time to review. Thank you for getting started with this and being willing to help maintain the recipes!.

Chempy is very important to my work, it’s a pleasure to do that. I'm sorry I didn't dedicate myself more recently, but the work has taken me a long time too.

@bjodah bjodah changed the title Add ChemPy Add ChemPy [ready for review] Nov 24, 2020
@chrisburr chrisburr merged commit ef4e474 into conda-forge:master Dec 8, 2020
@bjodah
Copy link
Member Author

bjodah commented Dec 8, 2020

@chrisburr thank you for the review!

@bjodah bjodah deleted the add-chempy branch December 8, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants