Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the newest version of the chempy available. #12678

Merged
merged 14 commits into from
Dec 8, 2020
Merged

Making the newest version of the chempy available. #12678

merged 14 commits into from
Dec 8, 2020

Conversation

ProfLeao
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/chempy) and found some lint.

Here's what I've got...

For recipes/chempy:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/chempy, recipes/pyodesys) and found some lint.

Here's what I've got...

For recipes/chempy:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/chempy, recipes/chempy/chempy, recipes/pyodesys, recipes/sym) and found some lint.

Here's what I've got...

For recipes/chempy:

  • There are 1 too many lines. There should be one empty line at the end of the file.

For recipes/chempy/chempy:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/chempy, recipes/pyodesys, recipes/sym) and found some lint.

Here's what I've got...

For recipes/chempy:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/chempy, recipes/pyodesys, recipes/sym) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/chemicals, recipes/chempy, recipes/pyodesys, recipes/sym) and found it was in an excellent condition.

@ProfLeao
Copy link
Contributor Author

@bjodah, update packages in progress.

@bjodah
Copy link
Member

bjodah commented Sep 17, 2020

Looks promising! Looks like there are only two dependencies left:

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/chemicals, recipes/chemicals/dot2tex, recipes/chemicals/pyneqsys, recipes/chempy, recipes/pyodesys, recipes/sym) and found some lint.

Here's what I've got...

For recipes/chemicals/dot2tex:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

For recipes/chemicals/pyneqsys:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/chemicals, recipes/chempy, recipes/dot2tex, recipes/pyneqsys, recipes/pyodesys, recipes/sym) and found it was in an excellent condition.

@ProfLeao
Copy link
Contributor Author

Looks promising! Looks like there are only two dependencies left:

* https://pypi.org/project/dot2tex/

* https://pypi.org/project/pyneqsys/

I didn't pay attention to these packages. Thanks.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sym) and found some lint.

Here's what I've got...

For recipes/sym:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sym) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dot2tex, recipes/sym) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/chemicals, recipes/dot2tex, recipes/sym) and found it was in an excellent condition.

recipes/sym/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/chemicals, recipes/dot2tex, recipes/pyodesys, recipes/sym) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/chemicals, recipes/dot2tex, recipes/pyneqsys, recipes/pyodesys, recipes/sym) and found it was in an excellent condition.

@ProfLeao
Copy link
Contributor Author

Dear @scopatz , cold you help me with this error?

@ProfLeao
Copy link
Contributor Author

Dear @bjodah, could u take a look at this error? Thanks!

@ProfLeao ProfLeao closed this Sep 18, 2020
@ProfLeao ProfLeao reopened this Sep 18, 2020
@bjodah
Copy link
Member

bjodah commented Sep 18, 2020 via email

@ProfLeao
Copy link
Contributor Author

on my phone, but looks like jupyter needs to be added to pyneqsys?

On Thu, 17 Sep 2020, 06:29 ProfLeao, @.***> wrote: @bjodah https://github.com/bjodah, update packages in progress. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12678 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADWUMCB6C3HZAKZ7MMI53TSGGGEPANCNFSM4RPWUQBQ .

Yes, but it is already listed. I'm certainly doing something wrong, as this is the first time I've done it.
https://github.com/ProfLeao/staged-recipes/blob/78e2f69334bead3afda055f979a7d734f9d18e29/recipes/pyneqsys/meta.yaml#L22-L25

@bjodah
Copy link
Member

bjodah commented Sep 19, 2020

huh, you're right. Then I'm afraid I don't know what is going on either.

@ProfLeao
Copy link
Contributor Author

huh, you're right. Then I'm afraid I don't know what is going on either.

No problem buddy, i'll fix this mysterious error.🕵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants