Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Aborted Requests #1714

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Retry Aborted Requests #1714

merged 4 commits into from
Oct 26, 2021

Conversation

ajimae
Copy link
Contributor

@ajimae ajimae commented Oct 14, 2021

Summary

Add retryOnAbort config

Description

Add config to enable retry an aborted request

Todo

  • Tests
    • Unit

Closes #1713

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1714 (79a1343) into master (9034675) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1714   +/-   ##
=======================================
  Coverage   98.65%   98.66%           
=======================================
  Files         128      128           
  Lines        3428     3434    +6     
  Branches      791      795    +4     
=======================================
+ Hits         3382     3388    +6     
  Misses         42       42           
  Partials        4        4           
Impacted Files Coverage Δ
packages/sdk-middleware-http/src/http.js 97.82% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9034675...79a1343. Read the comment docs.

@ajimae ajimae requested a review from jenschude October 14, 2021 12:35
- add config to enable retry an aborted request
@ajimae ajimae force-pushed the feat/add-retry-on-abort branch from 6edfdb8 to cd12403 Compare October 14, 2021 13:08
@ajimae ajimae linked an issue Oct 14, 2021 that may be closed by this pull request
@ajimae ajimae requested review from jherey and markus-azer October 18, 2021 08:50
@ajimae ajimae force-pushed the feat/add-retry-on-abort branch from 9b73bfc to 2fb6205 Compare October 19, 2021 10:10
Copy link
Contributor

@jherey jherey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks. Looks good to me.

Co-authored-by: Jeremiah Olufayo  <[email protected]>
@jenschude jenschude merged commit 1167644 into master Oct 26, 2021
@jenschude jenschude deleted the feat/add-retry-on-abort branch October 26, 2021 18:38
@jenschude jenschude mentioned this pull request Nov 17, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix retry for aborted requests
3 participants