Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retry for aborted requests #1713

Closed
kamaz opened this issue Oct 12, 2021 · 7 comments · Fixed by #1714
Closed

Fix retry for aborted requests #1713

kamaz opened this issue Oct 12, 2021 · 7 comments · Fixed by #1714
Assignees
Labels

Comments

@kamaz
Copy link
Contributor

kamaz commented Oct 12, 2021

Support reference number

N/A

Description

Aborted requests are not being retried when enableRetry is enabled because they reuse the same AbortController for try requests.

Expected Behavior

Aborted requests are being retried.

Current Behavior

On abort, subsequent aborts are being aborted instantaneously.

Context

When running performance test we see a number of request being aborted which could be due to Commercetools staling-out.

Possible Solution

#1712

@mitsch2000 mitsch2000 linked a pull request Oct 13, 2021 that will close this issue
1 task
@ashishhk ashishhk added the Major label Oct 14, 2021
@ajimae ajimae linked a pull request Oct 14, 2021 that will close this issue
1 task
@kamaz
Copy link
Contributor Author

kamaz commented Oct 29, 2021

@jenschude / @ajimae I was wondering when you are planning to release a new version so we can start using it.

@jenschude
Copy link
Contributor

The regular release cycle is the first monday of a month. So next week monday.

@jenschude
Copy link
Contributor

Oh wait. This repo is auto released once it's merged. So it should be already available

@kamaz
Copy link
Contributor Author

kamaz commented Oct 29, 2021

@jenschude I think that looks like Monday next week. I've checked the current version in NPM and it points to '6.0.11': '2021-04-01T18:20:07.459Z'

https://www.npmjs.com/package/@commercetools/sdk-middleware-http

Unless I'm missing something.

@jenschude
Copy link
Contributor

Hrmpf seems that the autorelease is broken. So we have something to fix for monday 😉

@kamaz
Copy link
Contributor Author

kamaz commented Nov 2, 2021

@jenschude I was wondering if you managed to fix the autorelease. I still don't see the http package is published.

We would like to start using ASAP if possible.

@jenschude
Copy link
Contributor

New version has been released today. Sorry for the delay, we are updating the release process so it will be more automated again :)

https://www.npmjs.com/package/@commercetools/sdk-middleware-http

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants