Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(playwright): Different behavior of see* and waitFor* when used in within #4557

Merged
merged 7 commits into from
Dec 10, 2024
Merged

fix(playwright): Different behavior of see* and waitFor* when used in within #4557

merged 7 commits into from
Dec 10, 2024

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

DavertMik
DavertMik reviewed Nov 11, 2024
View reviewed changes
lib/helper/Playwright.js Outdated Show resolved Hide resolved
@kobenguyent kobenguyent merged commit 6e259e9 into 3.x Dec 10, 2024
12 checks passed
@kobenguyent kobenguyent deleted the fix-wait-actions branch December 10, 2024 08:47
This was referenced Dec 10, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik DavertMik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different behavior of see* and waitFor* when used in within
2 participants
@kobenguyent @DavertMik