-
-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since Codecept 3.6.9, our test that looks for a date time doesn't find it (but it's there) #4632
Comments
hi @a-roberts I'm doubt if the issue is due to those PRs as they touch |
tried to reproduce with this html
but it works just fine for me. |
@kobenguyent We are using a Carbon DataGrid so it's entirely possible the locator is now different or the locator is the same but under the covers it's just not picking up the element OK now. Or rather, it finds it (based on my screenshot) but then somehow fails the match. Not sure. I'll try to spend some time looking into this later to find a minimal reproduce. I am sure under the covers there is a regular table in there so it should be OK. |
I have:
If I inspect the value of
(not that useful to help our debugging) This is on Codecept 3.6.9 where the problem is and if I downgrade to 3.6.7 where it works and look at the same values, I don't gain any useful insights. There aren't enough things i can inspect in this helper file alone to help me debug what's going on. I'm going to try and get the simplest reproduce for you and will push to my github. |
Thanks for trying it out. May you give this a try on your local?
|
^^ that failed too unfortunately
If I play with these lines
I removed .first() and get this output which may offer some clues
I would need more rows though to see if the HTML has my row with its data in. Do we have an equivalent of screen.debug we could use here? |
@a-roberts is it possible to print out the |
Yep, so if I put it it in the else
I get this output on 3.6.9:
If I do the same experiment on 3.6.6:
|
Thank you! Just noticed some difference here. On my local, it's
so your table is inside a frame. |
I wonder if we now need to provide some more information to the locator? *I've just realised I don't know what a frame is in this context - what I'd like to say is instead is...we haven't changed our code... Edit 2: I wonder if we were always relying on unintended behaviour that has since been fixed... |
I'd think that if you could provide a sample repo where we could try to reproduce and debug from there. It'll be great start point. |
I tried to switch to iframe and it works. Just curious if you also need to switch to that frame?
|
Hmm, am I not already on an iframe though from the i.amOnPage. check? Do you think I need to change the locate part now? I don't know enough about the frame versus iframe you're mentioning although it feels like I should.... |
I tried to simulate the iframe to load the table inside. if I switch to iframe, it works.
If I don't switch to iframe, I got the error.
|
Like this?
Anything I'm missing? Same error
(Appreciate all of the suggestions and help!) |
may you happen to share the html code of that webpage if that's possible? just the minimum version with obfuscated data ofc. |
Hi, we're seeing this issue and we've tried pinning to older versions - 3.6.7 is OK.
What are you trying to achieve?
We have a test that's been passing up until now and does so with 3.6.7.
I can't use 3.6.8 because of Error: Cannot find module 'invisi-data' (I noticed a hotfix around this in the commits).
It started failing today (it could have failed sooner, we only noticed it today).
What do you get instead?
The following (I've noticed the UI here says 3.6.2, but when I do an
npm list
I am on 3.6.7, 3.6.8, or 3.6.9 depending on the test I am doing - we want to be on the latest and tried downgrading twice and as part of that verified 3.6.7 is ok).This looks to me like it finds our text and then says it hasn't...
Details
We are using Playwright 1.49.1
The text was updated successfully, but these errors were encountered: