Removed variables with duplicate definitions in Ticket/Request #595
Conversation
…lds were defined both here in Ticket and in it's parent class, Request. The fact that these had different access modifers in each definition led to serialiation/marshalling problems in some libraries (GSON for instance). Relying now on the definition in the parent class and fix is seamless.
|
Hey, sorry I totally missed this comment. I did test this, but I did only test it in the context of JSON marshalling. It's presumable that this could break backwards compat with binary serialization, but I do not believe there is any way around that. The error in the class is there, and there is no other way to resolve that I am aware of, at least that is relatively simple. I think the bottom line is that a bug has existed for a while here (redundant definitions of the same class member with differing accessibility. One is private, one is protected and they are exposing the same piece of data) and this change should happen at some point so the library works correctly. Maybe it is a major version revision and can be communicated that there is some issues with backward compatibility when doing binary serialization? |
|
I agree with you, but without my suggestion of changing the |
|
Ahhh, definitely I agree wholeheartedly. Didn't see that suggestion, apologies. I'll update accordingly. Thanks, |
Fixes #573
Very simple/small fix, but will allow library to work correctly in an environment where GSON is used.