Cannot marshal Ticket to JSON

[afm497]

Describe the bug
Cannot, at least using both GSON and Jackson, marshal a Ticket to JSON. Multiple fields named priority. One in the Ticket itself, another in it's superclass, Request. The priority in Ticket is private, in Request it's protected.

To Reproduce
Steps to reproduce the behavior:

1. Using the API, grab a Ticket object.
2. Try to marshal to JSON using either GSON or Jackson. Though it probably would apply to others, only have used those.
3. See IllegalArgumentException referencing multiple fields named "priority".

Expected behavior
Ability to marshal Ticket object to JSON for proper transmission.

Additional context
Not sure anymore is needed, but happy provide anything additional.

[PierreBtz]

@afm497 while the shadowed field is indeed less than ideal, I'm unsure why it wouldn't work. Following code is working at producing a json:

    public static void main(String[] args) throws IOException {
        var ticket = new Ticket();
        ticket.setPriority(Priority.HIGH);
        var mapper = new ObjectMapper();
        mapper.writeValue(System.out, ticket);
    }

Please provide a fully self contained reproducer.

[afm497]

I guess we differ on what "less than ideal" covers :) Just for the record, I use your library and find it very worthwhile, valuable and sincerely thank you for your efforts in creating and sharing.

Quick snippet:

    public static void main(String[] args) {
        new Gson().toJson(new Ticket());
    }

will result in
java.lang.IllegalArgumentException: class org.zendesk.client.v2.model.Ticket declares multiple JSON fields named priority

So while yes, one could use a custom exclusion strategy, detect this kind of thing and work around it, it seems like either the field should be fixed to only declare once if they represent the same thing or transition to distinct fields.

I'll add, now that I see the package name there, I believe this is part of your library , but if not and it's coming from elsewhere, let me know.

[PierreBtz]

I agree with you, I'm afraid I just don't have time to invest on the library currently. Code change itself looks trivial, but testing nothing is broken is not. I'm happy to accept a PR though :)

[afm497]

Totally understand. I'll submit a PR for you here. Didn't want to do it out of the blue so glad we could connect here. Thanks very much for being open here.

[github-actions]

This issue/PR is stale because it has been opened 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[afm497]

Had totally forgotten to create PR but got a notification that the issue was going stale so finally made the PR. Not sure if there is anything else I would need to do to ensure it no longer is treated as stale, but hopefully the activity addresses it.