Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getUsersByExternalIds(String, String...) - resolves #548 #552

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

andy-may-at
Copy link
Contributor

User external IDs are Strings in the Zendesk API, but the existing getUsersByExternalId implementation only allowed getting users by an externalId that was a long.

…es-oss#548

User external IDs are Strings in the Zendesk API, but the existing getUsersByExternalId implementation only allowed getting users by an externalId that was a long.
PierreBtz
PierreBtz previously approved these changes Mar 9, 2023
Copy link
Collaborator

@PierreBtz PierreBtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I'd like if possible to see the wildcard import removed.

src/test/java/org/zendesk/client/v2/UserTest.java Outdated Show resolved Hide resolved
@PierreBtz PierreBtz merged commit 539f7e7 into cloudbees-oss:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants