-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable search for users by external_id where external_id is a String (not a long) #548
Comments
@andy-may-at indeed that doesn't seem correct. PR welcome, you can also deprecate the old method taking longs for future removal. |
Thanks @PierreBtz |
Is there history on why the api often does varargs with the double parameters? |
I assumed that it was a way of allowing |
Is it worth considering making the idArray method generic and using it for the previous Long and the new String case?
|
@colbya If we do that, but keep the signature of And if we change the signature to |
The method to retrieve users by external ID: (
public List<User> getUsersByExternalIds(long externalId, long... externalIds)
) expects the external IDs to belong
s, but the underlying value is aString
in the Zendesk APIIn my use case, our external IDs are Strings, so we can't search for users by external ID using this method,..
I propose to implementing an additional
public List<User> getUsersByExternalIds(String externalId, String... externalIds)
method whichI'll look to raise a PR for this shortly if the change would be welcomed
The text was updated successfully, but these errors were encountered: