Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table loses geometry after horizontal split and removing column #6439

Closed
FilipTokarski opened this issue Mar 16, 2020 · 3 comments Β· Fixed by ckeditor/ckeditor5-table#300
Closed
Assignees
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@FilipTokarski
Copy link
Member

πŸ“ Provide detailed reproduction steps (if any)

  1. Open some table test
  2. Select a cell and split horizontally
  3. Click Delete column

βœ”οΈ Expected result

Column is deleted

❌ Actual result

Geometry is lost, additional columns inserted, content changes cells:

16_table2

πŸ“ƒ Other details

It occurs on master, on online docs ( since version 11.1.0 ) it behaves a bit different - after deleting column, you can see there is a ~1px space between the last column and table border highlight ( with a few pixels rendered grey ):
16_table3

If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:table type:regression This issue reports a bug that was not present in the previous releases. labels Mar 16, 2020
@mlewand mlewand added this to the iteration 31 milestone Mar 16, 2020
@mlewand
Copy link
Contributor

mlewand commented Mar 18, 2020

It occurs on master, on online docs ( since version 11.1.0 ) it behaves a bit different - after deleting column, you can see there is a ~1px

The reason is that there's an empty row (with only a br) in the model:

That remind me of "it's highly possible that other commands might produce a markup like this in certain scenario" part in #6422 (comment) πŸ˜„

Luckily this time we have BR so it does not crash the code though.

It would be easy to adjust fix added in ckeditor/ckeditor5-table#278 to also act in case there's a row with only br in it.

@mlewand mlewand modified the milestones: iteration 31, nice-to-have Mar 18, 2020
@mlewand
Copy link
Contributor

mlewand commented Mar 18, 2020

Potentially related issue: #6406. Moving to nice-to-have milestone, see #6406 (comment).

@Reinmar Reinmar modified the milestones: nice-to-have, next Mar 24, 2020
@Reinmar Reinmar modified the milestones: next, iteration 31 Apr 2, 2020
@jodator
Copy link
Contributor

jodator commented Apr 3, 2020

One cannot simply writer.remove( tableRow ) in tables :/ #6545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants