Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The table breaks after removing a last header row #6437

Closed
Mgsy opened this issue Mar 16, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-table#301
Closed

The table breaks after removing a last header row #6437

Mgsy opened this issue Mar 16, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-table#301
Assignees
@jodator
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 31 (v19...

Comments

@Mgsy
Copy link
Member

Mgsy commented Mar 16, 2020

📝 Provide detailed reproduction steps (if any)

  1. Insert a table
  2. Put the caret in the last row
  3. Create a header row
  4. Delete header

✔️ Expected result

The row disappears properly.

❌ Actual result

The table breaks and the selection moves out of the table.
Screenshot 2020-03-16 at 08 34 41

📃 Other details

Note: It seems to be an old issue, it also occurs in v12.1.0

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed package:table labels Mar 16, 2020
@Mgsy Mgsy added this to the backlog milestone Mar 16, 2020
@Reinmar Reinmar modified the milestones: backlog, iteration 31 Apr 2, 2020
@jodator
Copy link
Contributor

jodator commented Apr 3, 2020

Might be fixed by #6439 - to check.

@jodator jodator mentioned this issue Apr 8, 2020
Merged
This was referenced Apr 17, 2020
Merged
Closed
Closed
Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 17, 2020
@Reinmar
Merge pull request #301 from ckeditor/i/6437
5e1fd28 
Fix: Removing the last header row no longer breaks the table in the editing view. Closes ckeditor/ckeditor5#6437.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge pull request #301 from ckeditor/i/6437
3c7c721 
Fix: Removing the last header row no longer breaks the table in the editing view. Closes #6437.
@jodator jodator mentioned this issue May 26, 2020
Closed
This was referenced Jul 8, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

I/6437: Fix - the table breaks after removing a last header row ckeditor/ckeditor5-table
4 participants
@Reinmar @jodator @mlewand @Mgsy