Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Add support for the config.initialData option in ClassicTestEditor and VirtualTestEditor. #181

Merged
merged 4 commits into from
Jun 25, 2019

Conversation

ma2ciek
Copy link
Contributor

@ma2ciek ma2ciek commented Jun 24, 2019

Suggested merge commit message (convention)

Internal: Added support for the config.initialData option in ClassicTestEditor and VirtualTestEditor. Closes ckeditor/ckeditor5#2904.


Additional information

Required by the ckeditor/ckeditor5-watchdog#2.

@ma2ciek ma2ciek requested a review from pjasiun June 24, 2019 10:16
@coveralls
Copy link

coveralls commented Jun 24, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 2699126 on t/180 into 5caa173 on master.

@@ -54,7 +54,7 @@ export default class ClassicTestEditor extends Editor {
/**
* @inheritDoc
*/
static create( element, config ) {
static create( element, config = {} ) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it more similar to the classic editor and allow also pass data as the first parameter.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassicTestEditor and VirtualTestEditor don't handle the initialData configuration
3 participants