Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClassicTestEditor and VirtualTestEditor don't handle the initialData configuration #2904

Closed
ma2ciek opened this issue Jun 19, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-core#181
Closed

ClassicTestEditor and VirtualTestEditor don't handle the initialData configuration #2904

ma2ciek opened this issue Jun 19, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-core#181
Labels
package:core type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 25

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Jun 19, 2019

Since it's said in its docs:

It contains full data pipepilne and the engine pipeline but without rendering to DOM.

I was expecting it should also support the configuration option.

This issue blocks the ckeditor/ckeditor5-watchdog#2

Requires the following PRs:
@ma2ciek
Copy link
Contributor Author

ma2ciek commented Jun 19, 2019

The same with ClassicTestEditor.

@ma2ciek ma2ciek changed the title VirtualTestEditor doesn't handle the initialData configuration ClassicTestEditor and VirtualTestEditor don't handle the initialData configuration Jun 19, 2019
@ma2ciek ma2ciek changed the title ClassicTestEditor and VirtualTestEditor don't handle the initialData configuration ClassicTestEditor and VirtualTestEditor don't handle the initialData configuration Jun 19, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-core Jun 25, 2019
Merge pull request #181 from ckeditor/t/180
21b3fd3 
Other: Added support for the `config.initialData` option in `ClassicTestEditor` and `VirtualTestEditor`. Added support to data as the first parameter in`ClassicTestEditor.create` method. Closes #180.
pjasiun referenced this issue in ckeditor/ckeditor5-typing Jun 25, 2019
Merge pull request #194 from ckeditor/t/ckeditor5-core/180
813594f 
Internal: Changed `VirtualTestEditor` to `ClassicTestEditor` in delete feature tests. Part of the https://github.com/ckeditor/ckeditor5-core/issues/180.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-core Oct 9, 2019
@mlewand mlewand added this to the iteration 25 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:core labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:core type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 25
2 participants
@ma2ciek @mlewand