VAL-142 Return actual value from completeFullPayment() #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ams9198
commented
Feb 14, 2023
contracts/Loan.sol
Outdated
| @@ -503,7 +503,7 @@ contract Loan is ILoan, BeaconImplementation { | |||
| _state = ILoanLifeCycleState.Matured; | |||
|
|
|||
| IPool(_pool).onLoanStateTransitioned(); | |||
| return payment; | |||
| return outstandingPrincipal.add(_fees.interestPayment); | |||
There was a problem hiding this comment.
Is this right? Would it be more accurate (and in the other payment function) to do interest payment + fees on top?
There was a problem hiding this comment.
An on-chain caller may want to know the breakdown of payments in the return value. With an analytics platform, e.g. Dune you might want an emitted event so you can accumulate the values.
Maybe for v1 we can just make them return nothing?
There was a problem hiding this comment.
Works for me. I'll update.
bricestacey
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also happy to just remove these return values -- not sure how valuable they are. @bricestacey what do you think?