VAL-142 Remove return values from Loan payment functions (#182)

* Return actual value from completeFullPayment() * Remove return value from both Loan payment functions
circlefin · Feb 15, 2023 · 6d01291 · 6d01291
1 parent c6cb66d
commit 6d01291
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/contracts/Loan.sol b/contracts/Loan.sol
@@ -394,11 +394,11 @@ contract Loan is ILoan, BeaconImplementation {
      */
     function completeNextPayment()
         external
+        override
         onlyNotPaused
         onlyPermittedBorrower
         onlyBorrower
         atState(ILoanLifeCycleState.Active)
-        returns (uint256)
     {
         require(paymentsRemaining > 0, "Loan: No more payments remain");
 
@@ -423,7 +423,6 @@ contract Loan is ILoan, BeaconImplementation {
         if (paymentsRemaining > 0) {
             paymentDueDate += settings.paymentPeriod * 1 days;
         }
-        return payment;
     }
 
     /**
@@ -451,11 +450,11 @@ contract Loan is ILoan, BeaconImplementation {
      */
     function completeFullPayment()
         external
+        override
         onlyNotPaused
         onlyPermittedBorrower
         onlyBorrower
         atState(ILoanLifeCycleState.Active)
-        returns (uint256)
     {
         uint256 scalingValue = LoanLib.RAY;
 
@@ -504,7 +503,6 @@ contract Loan is ILoan, BeaconImplementation {
         _state = ILoanLifeCycleState.Matured;
 
         IPool(_pool).onLoanStateTransitioned();
-        return payment;
     }
 
     /**

diff --git a/contracts/interfaces/ILoan.sol b/contracts/interfaces/ILoan.sol
@@ -163,12 +163,12 @@ interface ILoan {
     /**
      * @dev Complete the next payment according to loan schedule inclusive of all fees.
      */
-    function completeNextPayment() external returns (uint256);
+    function completeNextPayment() external;
 
     /**
      * @dev Complete the final payment of the loan.
      */
-    function completeFullPayment() external returns (uint256);
+    function completeFullPayment() external;
 
     /**
      * @dev Allows partial repayment of outstanding principal in open-term loans.