Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAL-43] Update PermissionedLoan to use override modifier pattern #122

Merged
merged 7 commits into from
Dec 1, 2022
Merged

[VAL-43] Update PermissionedLoan to use override modifier pattern #122

merged 7 commits into from
Dec 1, 2022

Conversation

venables
Copy link
Contributor

@venables venables commented Dec 1, 2022

Ensures all necessary methods are protected with the PoolAccessControl logic

Built on #116, only last commit is relevant

@venables venables changed the title Update PermissionedLoan to use override modifier pattern [VAL-43] Update PermissionedLoan to use override modifier pattern Dec 1, 2022
ams9198
ams9198 previously approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@ams9198 ams9198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@venables venables merged commit 2d03637 into circlefin:master Dec 1, 2022
@venables venables deleted the matt/val-43-borrower-revocation branch December 1, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricestacey bricestacey bricestacey approved these changes

@ams9198 ams9198 ams9198 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@venables @bricestacey @ams9198