Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAL-88] Add verite check for PoolAdmin and remove AllowList #116

Merged
merged 4 commits into from
Dec 1, 2022
Merged

[VAL-88] Add verite check for PoolAdmin and remove AllowList #116

merged 4 commits into from
Dec 1, 2022

Conversation

venables
Copy link
Contributor

  • Move shared Verite logic to inheritable contract VeriteAccessControl
  • Uses VeriteAccessControl in PoolAccessControl (with PoolAdmin set as the controller of the Verite logic)
  • Removes allowList from PoolAdminAccessControl
  • Uses VeriteAccessControl in PoolAdminAccessControl (with Operator set as the controller of the Verite logic)

@venables venables mentioned this pull request Dec 1, 2022
Merged
ams9198
ams9198 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@ams9198 ams9198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

contracts/permissioned/VeriteAccessControl.sol
* Other contracts should inherit this contract to add Verite-specific
* access control logic.
*/
contract VeriteAccessControl is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also make sense as an abstract type....can't think of a usecase where you'd actually want this contract as-is (where anyone could add any verifier / schema)?

@venables venables merged commit fc01838 into circlefin:master Dec 1, 2022
@venables venables deleted the matt/val-88-verite branch December 1, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ams9198 ams9198 ams9198 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@venables @ams9198