Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#508) Fix package iconUrl to be one that Chocolatey owns #521

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

pauby
Copy link
Member

@pauby pauby commented Aug 22, 2022

Description Of Changes

Updated the package iconUrl to be from one that Chocolatey owns.

Motivation and Context

Icon was pointing to somewhere we had no control over.

Testing

N/A.

Change Types Made

  • Bug fix (non-breaking change)
  • Feature / Enhancement (non-breaking change)
  • Breaking change (fix or feature that could cause existing functionality to change)
  • PowerShell code changes.

Related Issue

Fixes #508

Change Checklist

  • Requires a change to the documentation
  • Documentation has been updated
  • Tests to cover my changes, have been added
  • All new and existing tests passed.
  • PowerShell v2 compatibility checked.

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes the icon from a 128x104 pixels image, to an image that is 70x61 pixels.

Was this intended?

@pauby pauby force-pushed the fix/package-iconurl branch from f735cec to bc98d32 Compare August 23, 2022 11:19
@pauby
Copy link
Member Author

pauby commented Aug 23, 2022

Not really. I intended to just update the icon to point to the new image that we put onto img.chocolatey.org.

@pauby
Copy link
Member Author

pauby commented Aug 23, 2022

Updated it now and ready for re-review.

@gep13
Copy link
Member

gep13 commented Aug 23, 2022

Looking at the new URL's, it looks like the icon URL has changed in the other direction now, i.e. the dimensions of the image is larger:

image

I have no objections to getting this merged in, I just wanted to point this out.

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 9b5c0a0 into chocolatey:develop Aug 23, 2022
@gep13
Copy link
Member

gep13 commented Aug 23, 2022

@pauby thanks for getting these URL's fixed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update iconUrl to a domain owned directly by Chocolatey
2 participants