Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update iconUrl to a domain owned directly by Chocolatey #508

Closed
gep13 opened this issue Jul 14, 2022 · 4 comments · Fixed by #521
Closed

Update iconUrl to a domain owned directly by Chocolatey #508

gep13 opened this issue Jul 14, 2022 · 4 comments · Fixed by #521
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Milestone
3.0.1

Comments

@gep13
Copy link
Member

gep13 commented Jul 14, 2022 •
edited
Loading

Is Your Feature Request Related To A Problem? Please describe.

Currently, the iconUrl for the Boxstarter Chocolatey packages uses:

https://cdn.rawgit.com/chocolatey/boxstarter/master/Web/Images/boxLogo_sm.png

During the recent v3.0.0 release, this URL failed to validate, since the entire Web directory was removed from the Boxstarter GitHub repository. To prevent this from happening again, the iconUrl should be updated to a URL that is directly owned/maintained by Chocolatey.

Describe The Solution. Why is it needed?

Suggestion would be to add the Boxstarter logo to this repository and the iconUrl would be updated to start with https://img.chocolatey.org

The old image likely needs to remain in the GitHub Repository, so that the icon for older package versions continues to work.

Additional Context.

N/A

Related Issues

N/A
@pauby
Copy link
Member

pauby commented Aug 18, 2022

@st3phhays I'm happy to pick this up and put the image into img.chocolatey.org. However, where do you want it to go (folder) and what do you want it called (filename)? Not sure if you have a format for that over there.

@st3phhays
Copy link
Member

@pauby Thanks!

Copy these two images:

Place them into a folder on the images repo under logos/ (so it'll be img.chocolatey.org/logos/boxstarter-logo.png for example)

I'll put the rest of the Chocolatey logos in this folder as well once those are moved over.

@pauby
Copy link
Member

pauby commented Aug 22, 2022

Raised a PR to have the images added. Once that is merged we can complete this.

@pauby pauby mentioned this issue Aug 22, 2022
Closed
9 tasks
pauby added a commit to pauby/boxstarter that referenced this issue Aug 22, 2022
@pauby
(chocolatey#508) Fix package iconUrl
f735cec
@pauby pauby mentioned this issue Aug 22, 2022
Merged
9 tasks
pauby added a commit to pauby/boxstarter that referenced this issue Aug 23, 2022
@pauby
(chocolatey#508) Fix package iconUrl
bc98d32
gep13 added a commit that referenced this issue Aug 23, 2022
@gep13
Merge pull request #521 from pauby/fix/package-iconurl
9b5c0a0 
(#508) Fix package iconUrl to be one that Chocolatey owns
@gep13 gep13 added this to the 3.1.0 milestone Aug 23, 2022
@gep13 gep13 modified the milestones: 3.1.0, 3.0.1 Jun 6, 2023
@gep13 gep13 added the 4 - Done Code has been added to the repository, and has been reviewed by a team member label Jun 6, 2023
@gep13 gep13 changed the title Update iconUrl to a domain owned directly have Chocolatey Update iconUrl to a domain owned directly by Chocolatey Jun 6, 2023
@gep13 gep13 added the Bug Issues where something has happened which was not expected or intended label Jun 6, 2023
gep13 added a commit that referenced this issue Jun 6, 2023
@gep13
Merge branch 'hotfix/3.0.1'
ea42cee 
* hotfix/3.0.1:
  GH-518: fix Call-Chocolatey usage
  (GH-532) Use 'choco install' instead of cinst (#533)
  (#524) Fix Build Handling of Long Prerelease
  (maint) eol consistency
  (maint) .gitattributes new line
  (GH-501) Fix Propagation of VerbosePreference (#512)
  (#508) Fix package iconUrl
  Fixed typo in README.md
  Update README.md
  (maint) Re-instate the Boxstarter logo
  (maint) link boxstarter.org repository
  (maint) crlf in Markdown files!
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Jun 6, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
3.0.1
4 participants
@gep13 @choco-bot @pauby @st3phhays