Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CI (please ignore) #4768

Closed
wants to merge 1 commit into from

Conversation

dilijev
Copy link
Contributor

@dilijev dilijev commented Mar 1, 2018

See #4767

@dilijev
Copy link
Contributor Author

dilijev commented Mar 2, 2018

@dotnet-bot test dailies please

@dilijev
Copy link
Contributor Author

dilijev commented Mar 2, 2018

@dotnet-bot test this please

@dilijev
Copy link
Contributor Author

dilijev commented Mar 2, 2018

@Penguinwizzard want to take a look at the static analysis failures?

@dilijev
Copy link
Contributor Author

dilijev commented Mar 2, 2018

Note: tasks with dailies trigger are not generated for *-ci branches, so we'll have to check those after merging the change. Luckily failures in dailies are non-blocking. I don't see an obvious way to generate those tasks so they don't actually run the dailies for this branch on a daily trigger without writing a different generator which is special-purposed to the *-ci branches.

FYI @MSLaguana @boingoing

@dilijev
Copy link
Contributor Author

dilijev commented Mar 2, 2018

Good things:

Forced Dev14 detection for Legacy config is working:

https://ci2.dot.net/job/Microsoft_ChakraCore/job/release_1.8-ci/job/ci_legacy_x64_debug_prtest/1/console

16:20:49 D:\j\w\ci_legacy_x64---9dce0ce9>call .\jenkins\buildone.cmd x64 debug msbuild14 
16:20:49 Skipping Dev15 and trying Dev14...
16:20:50 MSBuild located at "C:\Program Files (x86)\msbuild\14.0\Bin"

Detection of Dev15 in modern config succeeded:

16:23:34 D:\j\w\arm_release_p---fdf127d1>call .\jenkins\buildone.cmd arm release  "/p:runcodeanalysis=true" 
16:23:34 Trying to locate Dev15...
16:23:34 MSBuild located at "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin"

Dev15 prefast ran under Windows *_release and detected issues based on new heuristics.

That's everything I was hoping for :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants