Modernize Windows Modern and Legacy Jenkins CI #4767

dilijev · 2018-03-01T23:28:43Z

Modern config:

Server 2016 (a recent-ish build ~= RS2, RS3)
VS 2017 (Dev15)

Legacy config:

Server 2008 R2 (Windows 7)
VS 2015 (Dev14)

See related issues and PRs:

Proposal: Become C++11 code base, Remove Support for VS 2013 builds #2549: Proposal: Become C++11 code base, Remove Support for VS 2013 builds
Drop support for Dev12 from Legacy test configuration. #2552: Drop support for Dev12 from Legacy test configuration.
Remove support for VS2013 (dev12) #3855: Remove support for VS2013 (dev12)

Fixes #4566: Update build configs (legacy -> dev14)

This reverts commit d24e902.

…2012 R2 + Dev14

dilijev · 2018-03-01T23:30:08Z

FYI @mmitche @jackhorton @MSLaguana @boingoing @Penguinwizzard

dilijev · 2018-03-01T23:30:14Z

@dotnet-bot test ci please

dilijev · 2018-03-01T23:31:31Z

After the generator job runs I'll add a test PR against this branch.

MSLaguana · 2018-03-01T23:38:04Z

Generator hit an error:
15:33:52 ERROR: (netci.groovy, line 234) No signature of method: netci$_run_closure2.call() is applicable for argument types: (java.lang.String, java.lang.String, null, java.lang.String, java.lang.Boolean, null, null) values: [Windows_NT, latest-dev15-5, null, -winBlue, true, null, null]

MSLaguana · 2018-03-01T23:39:46Z

netci.groovy

@@ -221,34 +231,45 @@ def CreateStyleCheckTasks = { taskString, taskName, checkName ->
 // INNER LOOP TASKS
 // ----------------

-CreateBuildTasks('Windows_NT', null, null, "-winBlue", true, null, null)
+CreateBuildTasks(latestWindowsMachine, latestWindowsMachineTag, null, "-winBlue", true, null, null)


Ah; you removed an additional null that you didn't need to. Needs a null after latestWindowsMachineTag

Ah, good catch, thanks.

dilijev · 2018-03-01T23:45:38Z

@dotnet-bot test ci please

jackhorton · 2018-03-01T23:51:39Z

Ill look more later, but any reason for targeting this on release/1.8-ci?

dilijev · 2018-03-01T23:55:43Z

Legacy builds were dropped from 1.8 with our drop of Dev12 support. Figured we should add the new legacy checks here to pick up the lineage (and it would be good to know if this effectively not-covered release of ChakraCore is actually broken on Win 7).

mmitche · 2018-03-02T00:44:26Z

@dotnet-bot test OSX static_osx_osx_debug

dilijev · 2018-03-02T01:18:26Z

@dotnet-bot
test OSX static_osx_osx_debug
test OSX static_osx_osx_test

mmitche · 2018-03-02T01:21:24Z

@dilijev We think there are some serious lab issues going on right now. The OSX jobs are going to fail again most likely.

dilijev · 2018-03-02T01:22:58Z

@mmitche okay, I'll hold off triggering them again. They're not the focus of this change anyway.

jackhorton

I still think that the xplat builds are a bit over the top, but perhaps thats better for a different PR? Also, once this gets to master, I will probably add a single x64_debug build for server 2016 + ICU (which will eventually go away once all 2016 builds opt into ICU by default)

jackhorton · 2018-03-02T02:23:58Z

Build/scripts/add_msbuild_path.cmd

@@ -57,7 +60,7 @@ if exist "%MSBUILD_PATH%\msbuild.exe" (
    goto :MSBuildFound
 )

-echo Dev14 not found, trying Dev12...
+echo Dev14 not found, trying to locate Dev12...


Why do we still bother trying to find dev12?

Good point.

jackhorton · 2018-03-02T02:26:40Z

netci.groovy

    'Ubuntu16.04': 'Ubuntu',
    'OSX': 'OSX'
 ]

+def defaultMachineTag = 'latest-or-auto'


nit: defaultWindowsMachineTag

jackhorton · 2018-03-02T02:29:20Z

netci.groovy

@@ -221,34 +231,45 @@ def CreateStyleCheckTasks = { taskString, taskName, checkName ->
 // INNER LOOP TASKS
 // ----------------

-CreateBuildTasks('Windows_NT', null, null, "-winBlue", true, null, null)
+CreateBuildTasks(latestWindowsMachine, latestWindowsMachineTag, null, null, "-winBlue", true, null, null)


I don't think we are supposed to be passing "-winBlue" for testExtra anymore. What does that flag even do? Enable WinBlue tests? Is the script so old that they weren't originally enabled by default?

Note that this is passed in a bunch of different places and should be cleaned up. Maybe make the jenkins script pass the appropriate flag for wherever its running so we don't have to specify it here?

I think -winBlue might enable "not Windows 7" tests which should probably continue running. Could be wrong but seems like we should just remove the winBlue tags and disable some tests on Windows 7.

If I'm not mistaken there are significant platform differences across Win7 (Server 2008 R2) Win8 (Server 2012) WinBlue (Server 2012 R2), and Win10 -- and we have test platform configurations and test tags reflecting all of these. Worth an audit on the test tags as a separate work item, but whether or not we currently use this, our tests still "depend" on this on the appropriate platform.

However, I'll make sure that the "testExtra" accurately reflects that platform that each leg will actually run on. If modern = Win10 (Server 2016) then "-winBlue" is incorrect.

jackhorton · 2018-03-02T02:30:37Z

netci.groovy

-    'Windows_NT', 'ci_lite', '"/p:BuildLite=true"', '-winBlue -lite', false, null, null)
+    latestWindowsMachine, latestWindowsMachineTag, 'ci_lite', '"/p:BuildLite=true"', '-winBlue -lite', false, null, null)
+// x64_debug Legacy
+CreateBuildTask(true, 'x64', 'debug',


So ci_lite and ci_disablejit don't get rolling builds. Is that intentional?

There's no need for rolling builds since they're intended to be daily builds. The PR-only tasks for these daily build configs were added as a minimal sanity check. This is by design. We can revisit this (or the general distinction of daily|rolling) as a separate discussion and work item if you think that's worthwhile.

boingoing

LGTM

dilijev · 2018-03-27T04:19:32Z

@dotnet-bot test ci please

dilijev · 2018-03-27T04:20:02Z

@MSLaguana @jackhorton @boingoing @Penguinwizzard That should cover all of the feedback. Thanks for the reviews!

dilijev · 2018-03-27T04:37:16Z

@dotnet-bot test ci please

dilijev · 2018-03-27T19:57:38Z

@dotnet-bot
test OSX _no_jit_shared_osx_osx_test
test OSX static_osx_osx_release
test OSX static_osx_osx_test

dilijev added 3 commits February 28, 2018 20:50

Revert "Remove Dev12 CI Builds"

8cbb049

This reverts commit d24e902.

Update script logic for forcing detection of a specific msbuild version.

bb059ae

Update Windows build matrix to Server 2016 + Dev15 / Legacy = Server …

b35e066

…2012 R2 + Dev14

dilijev added the Continuous Integration label Mar 1, 2018

dilijev changed the base branch from master to release/1.8 March 1, 2018 23:28

dilijev changed the title ~~Modernize CI~~ Modernize Windows Modern and Legacy Jenkins CI Mar 1, 2018

MSLaguana reviewed Mar 1, 2018

View reviewed changes

Fix error in groovy script.

484f177

dilijev mentioned this pull request Mar 1, 2018

Test CI (please ignore) #4768

Closed

dilijev requested review from Penguinwizzard, boingoing and jackhorton March 2, 2018 01:22

jackhorton approved these changes Mar 2, 2018

View reviewed changes

boingoing approved these changes Mar 2, 2018

View reviewed changes

Penguinwizzard approved these changes Mar 21, 2018

View reviewed changes

dilijev self-assigned this Mar 27, 2018

dilijev added 2 commits March 26, 2018 21:07

Remove msbuild version 12 detection logic.

6a529fb

Propagate defaultMachineTag throughout netci.groovy

d382ecc

Refactor and update platform flag for testExtra param

22cc5d3

dilijev force-pushed the release/1.8-ci branch from dd3020d to 22cc5d3 Compare March 27, 2018 04:37

dilijev added the Waiting label Mar 27, 2018

MSLaguana closed this Apr 17, 2018

MSLaguana deleted the release/1.8-ci branch April 17, 2018 20:20

This was referenced Jun 6, 2018

Address issues picked up by Dev15 code analysis #5272

Merged

Modernize CI configuration: Modern = 2016 + Dev15; Legacy = 2012 R2 + Dev14 #5280

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernize Windows Modern and Legacy Jenkins CI #4767

Modernize Windows Modern and Legacy Jenkins CI #4767

dilijev commented Mar 1, 2018 •

edited

Loading

dilijev commented Mar 1, 2018 •

edited

Loading

dilijev commented Mar 1, 2018

dilijev commented Mar 1, 2018

MSLaguana commented Mar 1, 2018

MSLaguana Mar 1, 2018

dilijev Mar 1, 2018

dilijev commented Mar 1, 2018

jackhorton commented Mar 1, 2018

dilijev commented Mar 1, 2018

mmitche commented Mar 2, 2018

dilijev commented Mar 2, 2018

mmitche commented Mar 2, 2018

dilijev commented Mar 2, 2018

jackhorton left a comment

jackhorton Mar 2, 2018

dilijev Mar 21, 2018

jackhorton Mar 2, 2018

jackhorton Mar 2, 2018

jackhorton Mar 2, 2018

boingoing Mar 2, 2018

dilijev Mar 21, 2018

jackhorton Mar 2, 2018

dilijev Mar 21, 2018

boingoing left a comment

dilijev commented Mar 27, 2018

dilijev commented Mar 27, 2018 •

edited

Loading

dilijev commented Mar 27, 2018

dilijev commented Mar 27, 2018

Modernize Windows Modern and Legacy Jenkins CI #4767

Modernize Windows Modern and Legacy Jenkins CI #4767

Conversation

dilijev commented Mar 1, 2018 • edited Loading

dilijev commented Mar 1, 2018 • edited Loading

dilijev commented Mar 1, 2018

dilijev commented Mar 1, 2018

MSLaguana commented Mar 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dilijev commented Mar 1, 2018

jackhorton commented Mar 1, 2018

dilijev commented Mar 1, 2018

mmitche commented Mar 2, 2018

dilijev commented Mar 2, 2018

mmitche commented Mar 2, 2018

dilijev commented Mar 2, 2018

jackhorton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boingoing left a comment

Choose a reason for hiding this comment

dilijev commented Mar 27, 2018

dilijev commented Mar 27, 2018 • edited Loading

dilijev commented Mar 27, 2018

dilijev commented Mar 27, 2018

dilijev commented Mar 1, 2018 •

edited

Loading

dilijev commented Mar 1, 2018 •

edited

Loading

dilijev commented Mar 27, 2018 •

edited

Loading