Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json keywords #11

Merged
merged 1 commit into from
Apr 7, 2016
Merged

Update package.json keywords #11

merged 1 commit into from
Apr 7, 2016

Conversation

keithamus
Copy link
Member

See chaijs/chaijs.github.io#34 for more.

If you're wondering why I want you to add these keywords, here is the reasoning for each one:

  • chai-plugin will let us index your plugin on the next version of the website. If you don't add this to your package.json, you wont be listed on our plugins page.
  • browser will let us know that your plugin supports the browser. Please don't add this keyword if you don't support the browser. If you don't add it we'll assume the plugin does not support browsers.
  • Any other keyword listed below has been listed there, because it was in our plugins.js file which is soon to be removed. If you don't want these keywords in your package.json, that's fine, but seeing as they're in our plugins.js I thought it'd be good measure to give you a chance to add them into your package.json. We'll use them to help filter our plugins page, so it is advisable to add them.

@keithamus
Copy link
Member Author

@Bartvds do you think you'll be able to merge this and make a release soon?

@Bartvds
Copy link
Contributor

Bartvds commented Apr 7, 2016

Hey, sorry for late reply. I really need to find a new owner for this package. I just posted an ask for this in issue #10 (with more followers clamouring for fixes). If someone credible steps up I will transfer soonest and we can get this sorted.

@keithamus
Copy link
Member Author

If you'd like @Bartvds - we can fold it into the chaijs organisation 😄

@Bartvds
Copy link
Contributor

Bartvds commented Apr 7, 2016

Cool, that would be ideal. I see your profile and memberships, qualifies as credible 😺

I'm looking at https://help.github.com/articles/transferring-a-repository/ and it is a few steps. Please let me know how you like to proceed on that.

I could transfer npm ownership and let you get something out quickly while we move the repos.

@keithamus
Copy link
Member Author

@Bartvds if you simply add me as an admin to the repo, and then I can move it to the chai org and get everything else sorted. You'll also need to add the npm chaijs user (https://www.npmjs.com/~chaijs) as a user to the npm package (you can do that here: https://www.npmjs.com/package/chai-fs/access). That should be everything 😄

@Bartvds
Copy link
Contributor

Bartvds commented Apr 7, 2016

Cool, I added chaijs npm owner just now and made you Collaborator on this repo (same thing as admin?).

@keithamus
Copy link
Member Author

@Bartvds doesn't seem to work. You could try transferring it into the chaijs org yourself, alternatively try transferring to me and I'll transfer it to the org.

@Bartvds
Copy link
Contributor

Bartvds commented Apr 7, 2016

Maybe can't move it as collaborator because it is a personal repos? I see no admin option in Settings.

I tried transfering to chaijs org but you got to be admin to be able to do that (the steps mentioned earlier). I also tried transferring to your account but you have a fork with same name 😆

@keithamus
Copy link
Member Author

@Bartvds I've invited you into the chai-fs team on the chai org. Please accept and then you should be able to transfer the repo 😄

@Bartvds
Copy link
Contributor

Bartvds commented Apr 7, 2016

Cool I accepted the invite and am part of chai-fs team.

Still no go though, I get "You don’t have admin rights to chaijs".

Looking at https://help.github.com/articles/transferring-a-repository/ it says it requires admin access 😦

Maybe it's better if you rename your fork so I move it to you?

@keithamus
Copy link
Member Author

Good idea, done 😄

@Bartvds
Copy link
Contributor

Bartvds commented Apr 7, 2016

When I try this it gives me: "keithamus already has a repository in the Bartvds/chai-fs network"

@keithamus
Copy link
Member Author

Okay, I've now deleted my fork. You should be able to move it now, surely 😵

@Bartvds
Copy link
Contributor

Bartvds commented Apr 7, 2016

🎉 you have 📧

@keithamus
Copy link
Member Author

🎉 that was more difficult than it needed to be but we got there!

@keithamus keithamus merged commit dfbf3d7 into chaijs:master Apr 7, 2016
@keithamus
Copy link
Member Author

Just FYI @Bartvds I've set you up as a team admin with write access. This means you should have the same permissions as before with regards to pulling, pushing, and can add new collabs as you see fit by adding them to the chai-fs team. Obviously under the chaijs org we will start to maintain the project too, but you still have full autonomy on it as well 😄

@Bartvds
Copy link
Contributor

Bartvds commented Apr 7, 2016

Yea, nice struggle but we made it. 👍

Thanks for the access and team status although I probably wouldn't mind if at some point of inactivity it downgrades or disappears. But kindly remove my npm ownership as I'd like to reduce my responsibilities for people's CI gear. 😺

@Turbo87
Copy link

Turbo87 commented Jun 22, 2016

@keithamus @Bartvds just FYI there is also https://github.com/Turbo87/chai-files now that is aimed at chai@3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants